Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827 )
Change subject: reduce code dup in handle_cn_data_ind() ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827/comment/33534f40_2cd21330 PS1, Line 376: if (!map->is_ps) { I'd personally first check for the type of procedure ("switch (message->procedureCode)") and then inside each message do whatever, to follow a kind of "decode" path, but fine anyway.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827/comment/d287c9ab_26112e4b PS1, Line 414: talloc_free(message); if rc==0, then these 2 get called: ranap_ran_rx_co_free(message) talloc_free(message)
are you sure this is not doublefreeing?