Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827 ) Change subject: reduce code dup in handle_cn_data_ind() ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827/comment/33534f40_2cd21330 PS1, Line 376: if (!map->is_ps) { I'd personally first check for the type of procedure ("switch (message->procedureCode)") and then inside each message do whatever, to follow a kind of "decode" path, but fine anyway. https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827/comment/d287c9ab_26112e4b PS1, Line 414: talloc_free(message); if rc==0, then these 2 get called: ranap_ran_rx_co_free(message) talloc_free(message) are you sure this is not doublefreeing? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4bca25d1643693cf3a9d3c49f35b29ff1dce0859 Gerrit-Change-Number: 28827 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Jul 2022 10:34:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment