Attention is currently required from: neels.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #1, Line 376: if (!map->is_ps) {

    I'd personally first check for the type of procedure ("switch (message->procedureCode)") and then inside each message do whatever, to follow a kind of "decode" path, but fine anyway.

  • Patch Set #1, Line 414: talloc_free(message);

    if rc==0, then these 2 get called:
    ranap_ran_rx_co_free(message)
    talloc_free(message)

    are you sure this is not doublefreeing?

To view, visit change 28827. To unsubscribe, or for help writing mail filters, visit settings.