Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 ) Change subject: add ps_rab_ass FSM to map GTP via UPF ...................................................................... Patch Set 2: (4 comments) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/29d202b0_07e98082 PS2, Line 193: /* Return true when the user configured GTP mapping to be enabled, by configuring a PFCP link to a UPF. I'm not sure we really want to disable this feature. It was noticed in some customer's tickets that some regular scenarios will fail if the HNBGW is not in thge middle of the GTP path. For instance IIRC if the UE conn is closed and some DL data arrives and the HNBGW needs to page the UE. I'm fine leaving it for now until the feature is completed, but we should drop this mode at some point. File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/75a9e9ff_87e9338c PS1, Line 230: LOGP(DHNBAP, LOGL_INFO, "deallocating UE context: id 0x%x, imsi %s, tmsi 0x%x\n",

missed this one, i think i needed it for debugging, could just drop it AFAICT this was not resolved.

https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/0fd07e41_fd46c938 PS1, Line 354: LOGP(DMAIN, LOGL_INFO, "Deallocating hnb_context\n");

this can probably go on a different commit. Same, not resolved.

File src/osmo-hnbgw/ps_rab_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/bbb8fd8d_dbf2f7da PS1, Line 797: .name = "PS_RAB_ST_WAIT_USE_COUNT",

WAIT_USE_COUNT Not resolved.

-- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic9bc30f322c4c6c6e82462d1da50cb15b336c63a Gerrit-Change-Number: 28816 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Jul 2022 10:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment