Attention is currently required from: neels.

View Change

4 comments:

• File include/osmocom/hnbgw/hnbgw.h:

  • Patch Set #2, Line 193: /* Return true when the user configured GTP mapping to be enabled, by configuring a PFCP link to a UPF.

    I'm not sure we really want to disable this feature. It was noticed in some customer's tickets that some regular scenarios will fail if the HNBGW is not in thge middle of the GTP path.
    For instance IIRC if the UE conn is closed and some DL data arrives and the HNBGW needs to page the UE.
    I'm fine leaving it for now until the feature is completed, but we should drop this mode at some point.

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #1, Line 230: LOGP(DHNBAP, LOGL_INFO, "deallocating UE context: id 0x%x, imsi %s, tmsi 0x%x\n",

    missed this one, i think i needed it for debugging, could just drop it

    AFAICT this was not resolved.

  • Patch Set #1, Line 354: LOGP(DMAIN, LOGL_INFO, "Deallocating hnb_context\n");

    this can probably go on a different commit.

    Same, not resolved.

• File src/osmo-hnbgw/ps_rab_fsm.c:

  • Patch Set #1, Line 797: .name = "PS_RAB_ST_WAIT_USE_COUNT",

    WAIT_USE_COUNT

    Not resolved.

To view, visit change 28816. To unsubscribe, or for help writing mail filters, visit settings.