Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )
Change subject: rspro_server: fix releasing timed out clients ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS2: I've reworked the patch.
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/ae4b2179_fb657093?u... : PS1, Line 773: if (conn->peer) {
Hence why you must keep "conn->peer = NULL;" before in line 926.
Done
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/5fb9be8a_7bca197e?u... : PS1, Line 923: /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */
With your proposal you'll end up with a double free of the osmo_stream_srv afaict, from the parent t […]
Done
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/28841391_c911cd26?u... : PS1, Line 926: osmo_stream_srv_destroy(peer);
osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it totally makes sense to do c […]
Done
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/70f5cfc9_f9ed5e41?u... : PS1, Line 938:
if (conn->fi) { […]
Re-ordered it.