[S] Change in osmo-remsim[master]: rspro_server: fix releasing timed out clients
Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email ) Change subject: rspro_server: fix releasing timed out clients ...................................................................... Patch Set 2: (5 comments) Patchset: PS2: I've reworked the patch. File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/ae4b2179_fb657093?u... : PS1, Line 773: if (conn->peer) {
Hence why you must keep "conn->peer = NULL;" before in line 926. Done
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/5fb9be8a_7bca197e?u... : PS1, Line 923: /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */
With your proposal you'll end up with a double free of the osmo_stream_srv afaict, from the parent t […] Done
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/28841391_c911cd26?u... : PS1, Line 926: osmo_stream_srv_destroy(peer);
osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it totally makes sense to do c […] Done
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/70f5cfc9_f9ed5e41?u... : PS1, Line 938:
if (conn->fi) { […] Re-ordered it.
-- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95 Gerrit-Change-Number: 42133 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 19 Feb 2026 17:37:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>
participants (1)
-
lynxis lazus