Attention is currently required from: pespin.

View Change

5 comments:

• Patchset:

  • Patch Set #2:

    I've reworked the patch.

• File src/server/rspro_server.c:

  • Patch Set #1, Line 773: if (conn->peer) {

    Hence why you must keep "conn->peer = NULL;" before in line 926.

    Done

  • Patch Set #1, Line 923: /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */

    With your proposal you'll end up with a double free of the osmo_stream_srv afaict, from the parent t […]

    Done

  • Patch Set #1, Line 926: osmo_stream_srv_destroy(peer);

    osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it totally makes sense to do c […]

    Done

  • Patch Set #1, Line 938:

    if (conn->fi) { […]

    Re-ordered it.

To view, visit change 42133. To unsubscribe, or for help writing mail filters, visit settings.