Attention is currently required from: pespin, msuraev.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 )
Change subject: pcu_sock: fix PCU socket accept behavior ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Let's reject new connections if one is already connected.
Hmm. I think I am misunderstanding something.
As far as I understand that would then mean that the close(fd) was correct as it rejects the new connection and this is what we want.
I am not sure if I understand the state->listen_bfd.when &= ~OSMO_FD_READ; correctly. As far as I understand that would stop listening on the first connection so we won't get another call to pcu_sock_accept() when another unwanted new connection comes in.
Given that we won't have to fix anything. Is this correct?