Attention is currently required from: pespin, msuraev.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    Let's reject new connections if one is already connected.

    Hmm. I think I am misunderstanding something.

    As far as I understand that would then mean that the close(fd) was correct as it rejects the new connection and this is what we want.

    I am not sure if I understand the state->listen_bfd.when &= ~OSMO_FD_READ; correctly. As far as I understand that would stop listening on the first connection so we won't get another call to pcu_sock_accept() when another unwanted new connection comes in.

    Given that we won't have to fix anything. Is this correct?

To view, visit change 31678. To unsubscribe, or for help writing mail filters, visit settings.