Attention is currently required from: pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior ...................................................................... Patch Set 2: (1 comment) Patchset: PS2:

Let's reject new connections if one is already connected. Hmm. I think I am misunderstanding something.

As far as I understand that would then mean that the close(fd) was correct as it rejects the new connection and this is what we want. I am not sure if I understand the state->listen_bfd.when &= ~OSMO_FD_READ; correctly. As far as I understand that would stop listening on the first connection so we won't get another call to pcu_sock_accept() when another unwanted new connection comes in. Given that we won't have to fix anything. Is this correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I695b93fd8109ef4943f36716563c147927611e85 Gerrit-Change-Number: 31678 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: msuraev <msuraev@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 10:35:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment