Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 )
Change subject: Add initial CSD support with external MNCC ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/msc/transaction.h:
https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/df3fc331_3f2e5cde PS1, Line 113: struct csd_filter csd;
This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc: […]
Then, if csd is actually extra filtering inside the general codecs filtering (as seems to suggest you last comment where CSD stuff is set in "&trans->cc.codecs.ms"), it may make sense to move this "csd" field inside the "codecs" struct? I'm not saying it should be done that way, just raising concerns.