Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 ) Change subject: Add initial CSD support with external MNCC ...................................................................... Patch Set 2: (1 comment) File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/df3fc331_3f2e5cde PS1, Line 113: struct csd_filter csd;
This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc: […] Then, if csd is actually extra filtering inside the general codecs filtering (as seems to suggest you last comment where CSD stuff is set in "&trans->cc.codecs.ms"), it may make sense to move this "csd" field inside the "codecs" struct? I'm not saying it should be done that way, just raising concerns.
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a Gerrit-Change-Number: 33369 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:31:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment