Attention is currently required from: osmith.

View Change

1 comment:

• File include/osmocom/msc/transaction.h:

  • Patch Set #1, Line 113: struct csd_filter csd;

    This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc: […]

    Then, if csd is actually extra filtering inside the general codecs filtering (as seems to suggest you last comment where CSD stuff is set in "&trans->cc.codecs.ms"), it may make sense to move this "csd" field inside the "codecs" struct?
    I'm not saying it should be done that way, just raising concerns.

To view, visit change 33369. To unsubscribe, or for help writing mail filters, visit settings.