[M] Change in osmo-bts[master]: paging: parse PCUIF data indication outside of paging.c

Attention is currently required from: pespin, dexter.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 )

Change subject: paging: parse PCUIF data indication outside of paging.c ......................................................................

Patch Set 5:

(2 comments)

File src/common/paging.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/13119fcf_1b03b1df PS5, Line 273: uint8_t macblock_len In GSM all MAC blocks must have `length == GSM_MACBLOCK_LEN`. IMO, it should be responsibility of the calling function to ensure the correct length. I see no need to pass and enforce the length here in this function. Not critical though.

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/e73b003b_8a8d5a4a PS5, Line 679: memcpy(imsi, data_req->data, 3); `osmo_strlcpy(&imsi[0], data_req->data, sizeof(imsi))` - this looks more readable and requires no prior initialization of `imsi[]`.