Attention is currently required from: pespin, dexter.

View Change

2 comments:

• File src/common/paging.c:

  • Patch Set #5, Line 273: uint8_t macblock_len

    In GSM all MAC blocks must have `length == GSM_MACBLOCK_LEN`. IMO, it should be responsibility of the calling function to ensure the correct length. I see no need to pass and enforce the length here in this function. Not critical though.

• File src/common/pcu_sock.c:

  • Patch Set #5, Line 679: memcpy(imsi, data_req->data, 3);

    `osmo_strlcpy(&imsi[0], data_req->data, sizeof(imsi))` - this looks more readable and requires no prior initialization of `imsi[]`.

To view, visit change 32733. To unsubscribe, or for help writing mail filters, visit settings.