Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email )
Change subject: s2b: allow to set the restart counter/recovery field ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/a9841de3_fa827... : PS2, Line 9: counter a 8 bit value **is** a 8 bit value
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/a5b06913_a4e78... : PS2, Line 112: monotonic timer could be to reproducible on systems What do you mean here? This comment is confusing...
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/9570d46b_65eb8... : PS2, Line 115: UserConfig This argument has two different names: `Options` in `start_link()` and `UserConfig` here. Let's stick to either of the two, for the sake of consistency.
Also, it's worth grouping/reworking all these list items into a map to avoid ugly constructions like this one. Might be an idea for a separate change.