Attention is currently required from: arehbein, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email )
Change subject: stream: Fix endless loop on server on client disconnect ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33196/comment/21c2fe32_c17d85bf PS3, Line 1349: osmo_stream_srv_set_flush_and_destroy(conn);
why aren't you simply disabling READ poll flag here if res == 0? […]
I don't think this is the correct fix and (partially) agree with Pau. On error (or EOF) we should simply destroy the connection.
The library code should not use osmo_stream_srv_set_flush_and_destroy(). This function is for the user to indicate that we should send out all pending messages and then close the connection.
I uploaded https://gerrit.osmocom.org/c/libosmo-netif/+/34338 which should fix this properly.