Attention is currently required from: arehbein, pespin.

Patch set 3:Code-Review -1

View Change

1 comment:

• File src/stream.c:

  • Patch Set #3, Line 1349: osmo_stream_srv_set_flush_and_destroy(conn);

    why aren't you simply disabling READ poll flag here if res == 0? […]

    I don't think this is the correct fix and (partially) agree with Pau. On error (or EOF) we should simply destroy the connection.

    The library code should not use osmo_stream_srv_set_flush_and_destroy(). This function is for the user to indicate that we should send out all pending messages and then close the connection.

    I uploaded https://gerrit.osmocom.org/c/libosmo-netif/+/34338 which should fix this properly.

To view, visit change 33196. To unsubscribe, or for help writing mail filters, visit settings.