Attention is currently required from: arehbein, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email ) Change subject: stream: Fix endless loop on server on client disconnect ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33196/comment/21c2fe32_c17d85bf PS3, Line 1349: osmo_stream_srv_set_flush_and_destroy(conn);
why aren't you simply disabling READ poll flag here if res == 0? […] I don't think this is the correct fix and (partially) agree with Pau. On error (or EOF) we should simply destroy the connection.
The library code should not use osmo_stream_srv_set_flush_and_destroy(). This function is for the user to indicate that we should send out all pending messages and then close the connection. I uploaded https://gerrit.osmocom.org/c/libosmo-netif/+/34338 which should fix this properly. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I012ddf14ae17642a52d34026d85ab6958cf488a1 Gerrit-Change-Number: 33196 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 07 Sep 2023 14:51:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment