Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email )
Change subject: layer23: migrate away from gsm48_generate_mid_from_* ......................................................................
Patch Set 4:
(2 comments)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33318/comment/ebc8fb3d_0aad9ea0 PS3, Line 2816: buf[1] = osmo_mobile_identity_encode_buf(buf+2, sizeof(buf)-2, &mi, false);
what if osmo_mobile_identity_encode_buf returns negative (error)?
Due to updated patch set this function is not used anymore.
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33318/comment/b4e739f4_c6a6cdde PS4, Line 3044: char buf[32];
this may be a bit short to print the whole osmo_mobile_identity_to_str_buf() in the case of IMSI? Di […]
The longest string would be "IMEI-SV-1234567890123456\0". This is below 32.