Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email ) Change subject: layer23: migrate away from gsm48_generate_mid_from_* ...................................................................... Patch Set 4: (2 comments) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33318/comment/ebc8fb3d_0aad9ea0 PS3, Line 2816: buf[1] = osmo_mobile_identity_encode_buf(buf+2, sizeof(buf)-2, &mi, false);

what if osmo_mobile_identity_encode_buf returns negative (error)? Due to updated patch set this function is not used anymore.

File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33318/comment/b4e739f4_c6a6cdde PS4, Line 3044: char buf[32];

this may be a bit short to print the whole osmo_mobile_identity_to_str_buf() in the case of IMSI? Di […] The longest string would be "IMEI-SV-1234567890123456\0". This is below 32.

-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda Gerrit-Change-Number: 33318 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jan 2024 12:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment