Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/host/layer23/src/mobile/gsm48_mm.c:

  • Patch Set #3, Line 2816: buf[1] = osmo_mobile_identity_encode_buf(buf+2, sizeof(buf)-2, &mi, false);

    what if osmo_mobile_identity_encode_buf returns negative (error)?

    Due to updated patch set this function is not used anymore.

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #4, Line 3044: char buf[32];

    this may be a bit short to print the whole osmo_mobile_identity_to_str_buf() in the case of IMSI? Di […]

    The longest string would be "IMEI-SV-1234567890123456\0". This is below 32.

To view, visit change 33318. To unsubscribe, or for help writing mail filters, visit settings.