Attention is currently required from: tobias.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33080 )
Change subject: modem_atcmd: make card reset cards.py compatible ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/33080/comment/0e8e0012_8f9111ac PS1, Line 7: make card reset cards.py compatible Thanks for your contribution. Reading the patch, I am trying to understand if we really need this. Most of the implementations raise an exception if resetting the card fails, and `cards.py` does not seem to expect/catch them. Only `pscs.py` returns an integer, both `serial.py` and `calypso.py` return `None`.
I suggest the following:
* modify `pcsc.py`, so that it does not `return 1`; * add a `try-except` block to `cards.py`.