Attention is currently required from: tobias. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33080 ) Change subject: modem_atcmd: make card reset cards.py compatible ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/33080/comment/0e8e0012_8f9111ac PS1, Line 7: make card reset cards.py compatible Thanks for your contribution. Reading the patch, I am trying to understand if we really need this. Most of the implementations raise an exception if resetting the card fails, and `cards.py` does not seem to expect/catch them. Only `pscs.py` returns an integer, both `serial.py` and `calypso.py` return `None`. I suggest the following: * modify `pcsc.py`, so that it does not `return 1`; * add a `try-except` block to `cards.py`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79d0fc87919efae4ee89881b7840c0e809bd7918 Gerrit-Change-Number: 33080 Gerrit-PatchSet: 1 Gerrit-Owner: tobias <t-osmocom.org@tobias.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: tobias <t-osmocom.org@tobias.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment