Attention is currently required from: tobias.

Patch set 1:Code-Review -1

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 7: make card reset cards.py compatible

    Thanks for your contribution. Reading the patch, I am trying to understand if we really need this. Most of the implementations raise an exception if resetting the card fails, and `cards.py` does not seem to expect/catch them. Only `pscs.py` returns an integer, both `serial.py` and `calypso.py` return `None`.

    I suggest the following:

    • modify `pcsc.py`, so that it does not `return 1`;
    • add a `try-except` block to `cards.py`.

To view, visit change 33080. To unsubscribe, or for help writing mail filters, visit settings.