Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email )
Change subject: pysim/log: also accept ANSI strings to specify the log message colors ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File pySim/log.py:
https://gerrit.osmocom.org/c/pysim/+/41713/comment/549fa4f7_543a1d35?usp=ema... : PS1, Line 111: if type(color) is str:
Thanks for the hint. I haven't had that in mind.
I believe Harald's suggestion was to do `isinstance(color, str)` instead of `type(color) is str`, but you are now doing both?
```
cmd2.Fg.RED
<Fg.RED: 31>
type(cmd2.Fg.RED)
<enum 'Fg'>
isinstance(cmd2.Fg.RED, str)
False ```
This patch most likely breaks passing cmd2 color.