Attention is currently required from: fixeria, laforge, neels, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend ......................................................................
Patch Set 26:
(3 comments)
File src/core/logging_emscripten.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/dbc3b989_edeb775a?u... : PS25, Line 44: const int msgLen = 4096;
Use MAX_LOG_SIZE from ./include/osmocom/core/logging_internal.h instead.
Replaced it with MAX_LOG_SIZE
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/d074b9b1_271e4961?u... : PS25, Line 47: char subsys_buf[16];
why is this 16 bytes?
This is kept at 16 bytes for consistency with `logging_gsmtap.c` The `gsmtap.h` header uses a fixed-size field `char subsys[16]` in structure `gsmtap_osmocore_log_hdr`, and I mirrored that field here to stay compatible.
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/517701a6_70e03d7d?u... : PS25, Line 57: if (msg[rc - 1] == '\n') msg[rc - 1] = '\0';
man vsnprintf: […]
Thanks for pointing this out, fixed.