Attention is currently required from: fixeria, laforge, neels, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 26: (3 comments) File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/dbc3b989_edeb775a?u... : PS25, Line 44: const int msgLen = 4096;

Use MAX_LOG_SIZE from ./include/osmocom/core/logging_internal.h instead. Replaced it with MAX_LOG_SIZE

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/d074b9b1_271e4961?u... : PS25, Line 47: char subsys_buf[16];

why is this 16 bytes? This is kept at 16 bytes for consistency with `logging_gsmtap.c` The `gsmtap.h` header uses a fixed-size field `char subsys[16]` in structure `gsmtap_osmocore_log_hdr`, and I mirrored that field here to stay compatible.

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/517701a6_70e03d7d?u... : PS25, Line 57: if (msg[rc - 1] == '\n') msg[rc - 1] = '\0';

man vsnprintf: […] Thanks for pointing this out, fixed.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 26 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 19:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>