Attention is currently required from: fixeria, laforge, neels, osmith, pespin.

View Change

3 comments:

• File src/core/logging_emscripten.c:

  • Patch Set #25, Line 44: const int msgLen = 4096;

    Use MAX_LOG_SIZE from ./include/osmocom/core/logging_internal.h instead.

    Replaced it with MAX_LOG_SIZE

  • Patch Set #25, Line 47: char subsys_buf[16];

    why is this 16 bytes?

    This is kept at 16 bytes for consistency with `logging_gsmtap.c`
    The `gsmtap.h` header uses a fixed-size field `char subsys[16]` in structure `gsmtap_osmocore_log_hdr`, and I mirrored that field here to stay compatible.

  • Patch Set #25, Line 57: if (msg[rc - 1] == '\n') msg[rc - 1] = '\0';

    man vsnprintf: […]

    Thanks for pointing this out, fixed.

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.