- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: runtime: check record/file size before write
by laforge 27 Oct '25

27 Oct '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41228?usp=email ) Change subject: runtime: check record/file size before write ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File pySim/runtime.py: https://gerrit.osmocom.org/c/pysim/+/41228/comment/2ba2d68d_90ac92c0?usp=em… : PS3, Line 555: warn "from warnings import warn" ist vmtl. noetig, siehe linter output -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7fa717d803ae79398d2c5daf92a7336be660c5ad Gerrit-Change-Number: 41228 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: AMR codec: add decoder homing frame const patterns
by laforge 27 Oct '25

27 Oct '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/41257?usp=email ) Change subject: AMR codec: add decoder homing frame const patterns ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1f8f8ec36cc13270a1d1fa633583107317abe894 Gerrit-Change-Number: 41257 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 27 Oct 2025 13:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: AMR codec: add conversion between s-bits and codec parameters
by laforge 27 Oct '25

27 Oct '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/41256?usp=email ) Change subject: AMR codec: add conversion between s-bits and codec parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I28eae702204d7f7ff164e17c5e26152a94a12cba Gerrit-Change-Number: 41256 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 27 Oct 2025 13:52:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by jolly 27 Oct '25

27 Oct '25

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Patch Set 2: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/e92cfa28_468701a5?… : PS2, Line 193: return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); > static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, uint16_t size, uint16_t headroom, […] I used some casting to make it clearer that there can't be an overflow. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 11:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by jolly 27 Oct '25

27 Oct '25

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Correctly calculate size iofd_msgb_alloc2() The storage size of 'headroom' must be larger than 16 bits. Otherwise a value above 65535 cannot be stored correctly and cause wrong calculation of msgb size. Related: Coverity CID#548925 Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 --- M src/core/osmo_io.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/41138/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove unused module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email ) Change subject: ES2Plus_Tests: remove unused module parameter ...................................................................... ES2Plus_Tests: remove unused module parameter Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Related: SYS#7339 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index 1f962cf..fa3f376 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -62,10 +62,6 @@ charstring mp_operator_id := "test.operator.com"; // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable - // SSL entirely. - boolean mp_use_ssl := true; // SSL with mutual TLS authentication enabled - - // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable // mutual authentication. boolean mp_use_mutual_tls := true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Gerrit-Change-Number: 41260 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove unused module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email ) Change subject: ES2Plus_Tests: remove unused module parameter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Gerrit-Change-Number: 41260 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 10:59:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: remove unused module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email ) Change subject: ES2Plus_Tests: remove unused module parameter ...................................................................... ES2Plus_Tests: remove unused module parameter Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Related: SYS#7339 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/41260/1 diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index 1f962cf..fa3f376 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -62,10 +62,6 @@ charstring mp_operator_id := "test.operator.com"; // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable - // SSL entirely. - boolean mp_use_ssl := true; // SSL with mutual TLS authentication enabled - - // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable // mutual authentication. boolean mp_use_mutual_tls := true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c Gerrit-Change-Number: 41260 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: move module parameter up
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email ) Change subject: smdpp_Tests: move module parameter up ...................................................................... smdpp_Tests: move module parameter up The module parameters are somewhere in the middle of the module code. Let's put them to the top to make it easier to find them. Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Related: SYS#7339 --- M smdpp/smdpp_Tests.ttcn 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 119ad08..9c453c2 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -34,6 +34,15 @@ import from esx_header_Types_JSON all; import from ES2Plus_Tests all; +/* Module Parameters */ +modulepar { + boolean mp_use_custom_tls_cert := true; + charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only + integer mp_es9plus_server_port_nist := 8000; + integer mp_es9plus_server_port_brp := 8001; + integer mp_es2plus_server_port := 8000; +} + /* C++ handles only crypto, TTCN-3 handles ASN.1 encoding/decoding most of the time */ /* RSP Client Management */ @@ -418,14 +427,6 @@ return pars; } -modulepar { - boolean mp_use_custom_tls_cert := true; - charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only - integer mp_es9plus_server_port_nist := 8000; - integer mp_es9plus_server_port_brp := 8001; - integer mp_es2plus_server_port := 8000; -} - private altstep as_Tguard() runs on MTC_CT { [] g_Tguard.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Tguard timeout"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Gerrit-Change-Number: 41259 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: move module parameter up
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email ) Change subject: smdpp_Tests: move module parameter up ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8 Gerrit-Change-Number: 41259 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 10:47:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log