- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: add "es2plus" prefix to module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41265?usp=email ) Change subject: ES2Plus_Tests: add "es2plus" prefix to module parameter ...................................................................... ES2Plus_Tests: add "es2plus" prefix to module parameter Let's prefix the module parameters to make it easier to understand their purpose. Related: SYS#7339 Change-Id: Idda9f287177cb1dce66bbef410bb1b7085f55b4d --- M smdpp/ES2Plus_Tests.cfg M smdpp/ES2Plus_Tests.ttcn 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg index 591b75b..8be08ff 100644 --- a/smdpp/ES2Plus_Tests.cfg +++ b/smdpp/ES2Plus_Tests.cfg @@ -10,7 +10,7 @@ # ES2+ specific parameters ES2Plus_Tests.mp_es2plus_server_host := "127.0.0.1" ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000 -ES2Plus_Tests.mp_operator_id := "test.operator.com" +ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com" [EXECUTE] ES2Plus_Tests.control \ No newline at end of file diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index ece4cc1..63e3a64 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -59,11 +59,11 @@ charstring mp_es2plus_client_key_path := "./test_certs/SK_MNO_ECDSA_NIST.pem"; // Sets the operator ID to be used on the ES2+ interface. (this parameter has no relation to SSL/TLS) - charstring mp_operator_id := "test.operator.com"; + charstring mp_es2plus_operator_id := "test.operator.com"; // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable // mutual authentication. - boolean mp_use_mutual_tls := true; + boolean mp_es2plus_use_mutual_tls := true; } // Test component - extend smdpp_ConnHdlr to reuse RSPClient functionality @@ -116,7 +116,7 @@ // Helper function to build ES2+ request header function f_es2plus_request_header() return JSON_ESx_RequestHeader { return { - functionRequesterIdentifier := mp_operator_id, + functionRequesterIdentifier := mp_es2plus_operator_id, functionCallIdentifier := f_gen_es2plus_uuid() }; } @@ -205,7 +205,7 @@ // Set authentication parameters once for all ES2+ operations var integer result := smdpp_Tests.ext_RSPClient_setAuthParams( g_rsp_client_handle, - mp_use_mutual_tls, + mp_es2plus_use_mutual_tls, mp_es2plus_client_cert_path, mp_es2plus_client_key_path ); @@ -979,7 +979,7 @@ // Temporarily set wrong authentication parameters var integer result := smdpp_Tests.ext_RSPClient_setAuthParams( g_rsp_client_handle, - mp_use_mutual_tls, + mp_es2plus_use_mutual_tls, c_wrong_cert_path, // Using wrong certificate c_wrong_key_path // Using wrong key ); @@ -1012,7 +1012,7 @@ // Restore correct auth params for cleanup smdpp_Tests.ext_RSPClient_setAuthParams( g_rsp_client_handle, - mp_use_mutual_tls, + mp_es2plus_use_mutual_tls, mp_es2plus_client_cert_path, mp_es2plus_client_key_path ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idda9f287177cb1dce66bbef410bb1b7085f55b4d Gerrit-Change-Number: 41265 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: add "es2plus" prefix to module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41265?usp=email ) Change subject: ES2Plus_Tests: add "es2plus" prefix to module parameter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idda9f287177cb1dce66bbef410bb1b7085f55b4d Gerrit-Change-Number: 41265 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: add "es2plus" prefix to module parameter
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41265?usp=email ) Change subject: ES2Plus_Tests: add "es2plus" prefix to module parameter ...................................................................... ES2Plus_Tests: add "es2plus" prefix to module parameter Let's prefix the module parameters to make it easier to understand their purpose. Related: SYS#7339 Change-Id: Idda9f287177cb1dce66bbef410bb1b7085f55b4d --- M smdpp/ES2Plus_Tests.cfg M smdpp/ES2Plus_Tests.ttcn 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/41265/1 diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg index 591b75b..8be08ff 100644 --- a/smdpp/ES2Plus_Tests.cfg +++ b/smdpp/ES2Plus_Tests.cfg @@ -10,7 +10,7 @@ # ES2+ specific parameters ES2Plus_Tests.mp_es2plus_server_host := "127.0.0.1" ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000 -ES2Plus_Tests.mp_operator_id := "test.operator.com" +ES2Plus_Tests.mp_es2plus_operator_id := "test.operator.com" [EXECUTE] ES2Plus_Tests.control \ No newline at end of file diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index ece4cc1..63e3a64 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -59,11 +59,11 @@ charstring mp_es2plus_client_key_path := "./test_certs/SK_MNO_ECDSA_NIST.pem"; // Sets the operator ID to be used on the ES2+ interface. (this parameter has no relation to SSL/TLS) - charstring mp_operator_id := "test.operator.com"; + charstring mp_es2plus_operator_id := "test.operator.com"; // ES2+ normally uses SSL with client authentication, however for debug purposes it is possible to disable // mutual authentication. - boolean mp_use_mutual_tls := true; + boolean mp_es2plus_use_mutual_tls := true; } // Test component - extend smdpp_ConnHdlr to reuse RSPClient functionality @@ -116,7 +116,7 @@ // Helper function to build ES2+ request header function f_es2plus_request_header() return JSON_ESx_RequestHeader { return { - functionRequesterIdentifier := mp_operator_id, + functionRequesterIdentifier := mp_es2plus_operator_id, functionCallIdentifier := f_gen_es2plus_uuid() }; } @@ -205,7 +205,7 @@ // Set authentication parameters once for all ES2+ operations var integer result := smdpp_Tests.ext_RSPClient_setAuthParams( g_rsp_client_handle, - mp_use_mutual_tls, + mp_es2plus_use_mutual_tls, mp_es2plus_client_cert_path, mp_es2plus_client_key_path ); @@ -979,7 +979,7 @@ // Temporarily set wrong authentication parameters var integer result := smdpp_Tests.ext_RSPClient_setAuthParams( g_rsp_client_handle, - mp_use_mutual_tls, + mp_es2plus_use_mutual_tls, c_wrong_cert_path, // Using wrong certificate c_wrong_key_path // Using wrong key ); @@ -1012,7 +1012,7 @@ // Restore correct auth params for cleanup smdpp_Tests.ext_RSPClient_setAuthParams( g_rsp_client_handle, - mp_use_mutual_tls, + mp_es2plus_use_mutual_tls, mp_es2plus_client_cert_path, mp_es2plus_client_key_path ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idda9f287177cb1dce66bbef410bb1b7085f55b4d Gerrit-Change-Number: 41265 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: improve error messages when setting verdict in f_init_...
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email ) Change subject: ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus ...................................................................... ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus It is not enough to say something has failed, it is also important to say what exactly and what for. Related: SYS#7339 Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index fa3f376..ece4cc1 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -198,7 +198,7 @@ ); if (g_rsp_client_handle < 0) { - setverdict(fail, "Failed to initialize RSP client"); + setverdict(fail, "Failed to initialize RSP client for ES2+"); mtc.stop; } @@ -211,7 +211,7 @@ ); if (result != 0) { - setverdict(fail, "Failed to set authentication parameters"); + setverdict(fail, "Failed to set RSP client authentication parameters for ES2+"); mtc.stop; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6 Gerrit-Change-Number: 41264 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: improve error messages when setting verdict in f_init_...
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email ) Change subject: ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6 Gerrit-Change-Number: 41264 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:29:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: improve error messages when setting verdict in f_init_...
by dexter 27 Oct '25

27 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email ) Change subject: ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus ...................................................................... ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus It is not enough to say something has failed, it is also important to say what exactly and what for. Related: SYS#7339 Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6 --- M smdpp/ES2Plus_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/41264/1 diff --git a/smdpp/ES2Plus_Tests.ttcn b/smdpp/ES2Plus_Tests.ttcn index fa3f376..ece4cc1 100644 --- a/smdpp/ES2Plus_Tests.ttcn +++ b/smdpp/ES2Plus_Tests.ttcn @@ -198,7 +198,7 @@ ); if (g_rsp_client_handle < 0) { - setverdict(fail, "Failed to initialize RSP client"); + setverdict(fail, "Failed to initialize RSP client for ES2+"); mtc.stop; } @@ -211,7 +211,7 @@ ); if (result != 0) { - setverdict(fail, "Failed to set authentication parameters"); + setverdict(fail, "Failed to set RSP client authentication parameters for ES2+"); mtc.stop; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6 Gerrit-Change-Number: 41264 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests.cfg: remove unused testport parameters
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41263?usp=email ) Change subject: smdpp_Tests.cfg: remove unused testport parameters ...................................................................... smdpp_Tests.cfg: remove unused testport parameters The testsuite uses a custom libcurl based sublayer that handles all the HTTP related tasks. Let's remove the HTTP_server_port related testport parameters. Change-Id: If58675f4243250381d407722c52e8e2384aa4f22 Related: SYS#7339 --- M smdpp/smdpp_Tests.cfg 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg index 1b34dae..2171d44 100644 --- a/smdpp/smdpp_Tests.cfg +++ b/smdpp/smdpp_Tests.cfg @@ -16,8 +16,6 @@ *.ConsoleMask:=ERROR | TESTCASE | USER | VERDICTOP | WARNING ; [TESTPORT_PARAMETERS] -system.HTTP_server_port.KEYFILE := "../ipad/example_ca/pki/private/alttest.key" -system.HTTP_server_port.CERTIFICATEFILE := "../ipad/example_ca/pki/issued/alttest.crt" [MODULE_PARAMETERS] smdpp_Tests.mp_es9plus_server_port_nist := 8000 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If58675f4243250381d407722c52e8e2384aa4f22 Gerrit-Change-Number: 41263 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests.cfg: remove unused testport parameters
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41263?usp=email ) Change subject: smdpp_Tests.cfg: remove unused testport parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If58675f4243250381d407722c52e8e2384aa4f22 Gerrit-Change-Number: 41263 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up
by dexter 27 Oct '25

27 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email ) Change subject: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up ...................................................................... ES2Plus_Tests: move [TESTPORT_PARAMETERS] up We normally have the [TESTPORT_PARAMETERS] right below [LOGGING] Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6 Related: SYS#7339 --- M smdpp/ES2Plus_Tests.cfg 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/smdpp/ES2Plus_Tests.cfg b/smdpp/ES2Plus_Tests.cfg index 1b46c47..591b75b 100644 --- a/smdpp/ES2Plus_Tests.cfg +++ b/smdpp/ES2Plus_Tests.cfg @@ -4,13 +4,13 @@ LogFile := "ES2Plus_Tests.%e.%h.%r.%s" LogSourceInfo := Stack +[TESTPORT_PARAMETERS] + [MODULE_PARAMETERS] # ES2+ specific parameters ES2Plus_Tests.mp_es2plus_server_host := "127.0.0.1" ES2Plus_Tests.mp_es2plus_server_port := 8000 # NIST tests use port 8000 ES2Plus_Tests.mp_operator_id := "test.operator.com" -[TESTPORT_PARAMETERS] - [EXECUTE] ES2Plus_Tests.control \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6 Gerrit-Change-Number: 41262 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up
by dexter 27 Oct '25

27 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email ) Change subject: ES2Plus_Tests: move [TESTPORT_PARAMETERS] up ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6 Gerrit-Change-Number: 41262 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Oct 2025 14:24:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log