Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27070 )
Change subject: open5gs-master: install dependencies using apt-get build-dep
......................................................................
Patch Set 3:
(1 comment)
File open5gs-master/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/27070/comment/4639121e_6f7…
PS3, Line 32: ADD https://api.github.com/repos/$GITHUB_USER/$GITHUB_REPO/git/refs/heads/$OPEN… /root/open5gs-ver.json
This ADD line needs to be moved below the first "apt-get build-dep -y ."
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27070
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I71ad7256116ee30f15aff38fd38588aa2bfab456
Gerrit-Change-Number: 27070
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 09:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/27075 )
Change subject: debian: add new 'libosmo-mslookup-utils' package
......................................................................
Patch Set 2:
(1 comment)
File debian/control:
https://gerrit.osmocom.org/c/osmo-hlr/+/27075/comment/5c5f89c3_323458af
PS2, Line 83: Package: libosmo-mslookup-utils
> I'd rather call it osmo-mslookup-utils, since this is not really packaging a library, but a set of u […]
I don't have a strong opinion here. We have libosmocore-utils, so why not?
Let's see what the others think, 'osmo-mslookup-utils' also looks good to me.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I9dbe00187678a5032fb4ae32b496892fdc86ddb7
Gerrit-Change-Number: 27075
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 09:06:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/27074 )
Change subject: fixup: debian: remove unneeded dependency libdbd-sqlite3
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
> Actually, it's not me saying that libdbd-sqlite3 is not needed ;) […]
Ah I see, so it was actually already removed from Dependencies list (by me) :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27074
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3ece7c32151f6f334d0595fdbf9099c930b22bb9
Gerrit-Change-Number: 27074
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 09:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/27074 )
Change subject: fixup: debian: remove unneeded dependency libdbd-sqlite3
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Why do you say it's not needed? Can you argument that?
Actually, it's not me saying that libdbd-sqlite3 is not needed ;)
commit 32c38f09e5fda3e723cdbb0041c0703a3c31ef4d
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Fri Sep 29 14:17:11 2017 +0200
debian: remove unneeded dependency libdbd-sqlite3
Take the opportunity to remove duplicated pkg-config dependency.
Change-Id: I5bfe9c71740c1ced5bad0a41dfca568b9e00070c
This patch simply removes a leftover from your patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27074
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3ece7c32151f6f334d0595fdbf9099c930b22bb9
Gerrit-Change-Number: 27074
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 09:01:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27078
to look at the new patch set (#2).
Change subject: BSC_Tests_VAMOS: fix TC_chan_act_to_vamos: deactivate lchan
......................................................................
BSC_Tests_VAMOS: fix TC_chan_act_to_vamos: deactivate lchan
Keeping the logical channel active may affect test cases executed
after TC_chan_act_to_vamos. Clean up after the test to avoid that.
Change-Id: Id0e3fb6a2f7e97ef854bff95adbc715d6f41f069
Related: OS#5444
---
M bsc/BSC_Tests_VAMOS.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/27078/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id0e3fb6a2f7e97ef854bff95adbc715d6f41f069
Gerrit-Change-Number: 27078
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27079
to look at the new patch set (#2).
Change subject: BSC_Tests_VAMOS: fix f_TC_mode_modify_to_vamos(): clean up lchan
......................................................................
BSC_Tests_VAMOS: fix f_TC_mode_modify_to_vamos(): clean up lchan
This change makes the following test cases pass:
* TC_mode_modify_to_vamos_fr
* TC_mode_modify_to_vamos_hr
Change-Id: Icb47e39a5466a1232cda03e1e04b0c88f3927659
Related: OS#5444
---
M bsc/BSC_Tests_VAMOS.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/27079/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27079
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icb47e39a5466a1232cda03e1e04b0c88f3927659
Gerrit-Change-Number: 27079
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27077 )
Change subject: fixup: debian-bullseye-titan: run 8 parallel jobs for 'make deps'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I8fe9ff0b7c27ae7c71bd9bac6048b3073adf6bda
Gerrit-Change-Number: 27077
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 08:48:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment