Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27016 )
Change subject: Allow configuration of interfaces/lines via VTY
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
It fails to re-read the config files it write.
<0000> intf_line.c:154 (I0) Created
<0000> intf_line.c:251 (I0:L0) Created
There is no such command.
Error occurred during reading the below line:
mode CHANNELIZED
<0000> osmo-e1d.c:183 Failed to parse the config file 'osmo-e1d.cfg'
The watchdog running for interfaces that are in the config but not connected is also kind of annoying, but then again it's the same for when the link is down, I think there is another issue for that.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27016
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I89b57b688b68901f87d9683ab9294772ee747d77
Gerrit-Change-Number: 27016
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 31 Jan 2022 12:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: bjoern, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 )
Change subject: implement shell command to update PLMN in IMSI
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I personally also wouldn't have a use case for this, but given that it is very non-intrusive and you have a use case for it, I think it should be merged. Somehow I didn't notice this patch at all until today.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26959
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc
Gerrit-Change-Number: 26959
Gerrit-PatchSet: 2
Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: roox, tnt, roh.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 )
Change subject: icE1usb: Move GPS-DO USB control to separate USB interface
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Looks good. The minor details I'm not sure about : […]
protocols: Yes, I figured the same, but thought that 0x00... 0xcf is by far sufficient for new frame formats, so 0xD0 ("DO") can be used for the GPS-DO?
requests: I thought it's good if they don't overlap with the interface requests to the E1 interface so we possibly more easily catch them if sent to the wrong interface.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254
Gerrit-Change-Number: 27017
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: roox <mardnh(a)gmx.de>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: roh <jsteiger(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:46:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment
Attention is currently required from: laforge, bjoern, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 )
Change subject: implement shell command to update PLMN in IMSI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> is this an desirable feature? if yes how do we continue, is there anything i should change? […]
I don't use pySim that often, so I don't have a strong opinion here. Not sure why would one need to change the PLMN part but keep the rest unchanged? I guess you're brute-forcing some hard-coded MNC/MNC lists in order to unlock some functionality in the UE? Let's see what the others think.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26959
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc
Gerrit-Change-Number: 26959
Gerrit-PatchSet: 2
Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-MessageType: comment
Attention is currently required from: roox, laforge, roh.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 )
Change subject: icE1usb: Move GPS-DO USB control to separate USB interface
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Looks good. The minor details I'm not sure about :
- using 0xd0 protocol vs another subclass for the GPSDO interface. I figured protocols could be used for different frame format in the future or something. Doesn't matter much.
- requests numbers starting at 0x10, they're now at intf level so technically they don't really need to.
Neither of which probably matter, just what I noticed while reading.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254
Gerrit-Change-Number: 27017
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: roox <mardnh(a)gmx.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: roh <jsteiger(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:37:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
bjoern has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 )
Change subject: implement shell command to update PLMN in IMSI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
is this an desirable feature? if yes how do we continue, is there anything i should change?
i was in need of such a functionality, however if it is not wanted by the majority here i keep it in a private fork.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26959
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc
Gerrit-Change-Number: 26959
Gerrit-PatchSet: 2
Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:34:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27010 )
Change subject: tests/logging: also test printing the filename information
......................................................................
tests/logging: also test printing the filename information
This commit demonstrates a bug introduced in [1], which can be
observed when the logging is configured to print the filename
*after* the logging message (LOG_FILENAME_POS_HEADER_END):
logging print file 1 last
^^^^
In this mode, the code in _output_buf() overwrites the '\n' sybmol
contained in the logging message itself by shifting the 'offset'
backwards, and appends the nipped '\n' after the filename info.
The problem is that the 'len' variable is not updated in this case,
so the resulting length includes +1 character - '\0', which gets
printed at the end of every logging line.
Interestingly enough, this problem affects only the wqueue mode.
Change-Id: I54bf5e5c036efb1908232fe3d8e8e2989715fbb3
Related: [1] I393907b3c9e0cc1145e102328adad0a83ee13a9f
---
M tests/logging/logging_test.c
M tests/logging/logging_test_stream.err
M tests/logging/logging_test_wqueue.err
3 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/tests/logging/logging_test.c b/tests/logging/logging_test.c
index 12a7374..3548b1d 100644
--- a/tests/logging/logging_test.c
+++ b/tests/logging/logging_test.c
@@ -130,5 +130,13 @@
log_set_category_filter(stderr_target, DLGLOBAL, 1, LOGL_DEBUG);
DEBUGP(DLGLOBAL, "You should see this (DLGLOBAL on DEBUG)\n");
+ /* Test printing of the filename */
+ log_set_print_filename2(stderr_target, LOG_FILENAME_BASENAME);
+
+ log_set_print_filename_pos(stderr_target, LOG_FILENAME_POS_HEADER_END);
+ DEBUGP(DLGLOBAL, "A message with source info printed first\n");
+ log_set_print_filename_pos(stderr_target, LOG_FILENAME_POS_LINE_END);
+ DEBUGP(DLGLOBAL, "A message with source info printed last\n");
+
return 0;
}
diff --git a/tests/logging/logging_test_stream.err b/tests/logging/logging_test_stream.err
index 17b3cad..01ab878 100644
--- a/tests/logging/logging_test_stream.err
+++ b/tests/logging/logging_test_stream.err
@@ -7,3 +7,5 @@
DLGLOBAL You should see this on DLGLOBAL (d)
DLGLOBAL You should see this on DLGLOBAL (e)
DLGLOBAL You should see this (DLGLOBAL on DEBUG)
+DLGLOBAL logging_test.c:137 A message with source info printed first
+DLGLOBAL A message with source info printed last (logging_test.c:139)
diff --git a/tests/logging/logging_test_wqueue.err b/tests/logging/logging_test_wqueue.err
index 17b3cad..3e2008b 100644
--- a/tests/logging/logging_test_wqueue.err
+++ b/tests/logging/logging_test_wqueue.err
Binary files differ
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I54bf5e5c036efb1908232fe3d8e8e2989715fbb3
Gerrit-Change-Number: 27010
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged