Attention is currently required from: lynxis lazus.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 )
Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................
Patch Set 3:
(1 comment)
File src/gb/gprs_ns2_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/23184/comment/a7b9d28d_649938d0
PS2, Line 2074: NS Entity ID (NSEI)\n
> Just to clarify, we're talking about the help message for the 'nse' part of the command's vector, no […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 25 Mar 2022 17:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27572 )
Change subject: libosmocore.spec: Make libosmocore-devel require libsctp
......................................................................
libosmocore.spec: Make libosmocore-devel require libsctp
Now that the libosmo*.pc files 'Require' the libsctp pkg-config
file to be installed, we need an explicit package dependency
from libosmocore-devel to lksctp-tools-devel, the package providing
the related libsctp.pc file.
Change-Id: I967369f6726e88946872881d298ab90440ca2c0e
---
M contrib/libosmocore.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in
index c2fe738..d699b58 100644
--- a/contrib/libosmocore.spec.in
+++ b/contrib/libosmocore.spec.in
@@ -129,6 +129,7 @@
Group: Development/Libraries/C and C++
Requires: libosmocore18 = %version
Requires: libtalloc-devel
+Requires: lksctp-tools-devel
%description -n libosmocore-devel
libosmocore is a library with various utility functions shared
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27572
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I967369f6726e88946872881d298ab90440ca2c0e
Gerrit-Change-Number: 27572
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge, daniel, lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 )
Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................
Patch Set 3:
(1 comment)
File src/gb/gprs_ns2_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/23184/comment/4135a609_3114171a
PS2, Line 2074: NS Entity ID (NSEI)\n
> it's working for both persistent as not persistent. I don't understand what you mean here.
Just to clarify, we're talking about the help message for the 'nse' part of the command's vector, not the '<0-65535>'. I checked what we have in cfg_ns_nsei_cmd, and there it is "Persistent NS Entity". If this command applies for both persistent as not persistent, then the help string should be "NSE specific commands" or something like that.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 25 Mar 2022 14:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria, daniel.
Hello Jenkins Builder, daniel,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/23184
to look at the new patch set (#3).
Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................
gprs_ns2: add vty `nse <0-65535> restart sns`
Allow to restart SNS procedure and initiate a SNS-SIZE procedure with Reset.
SGSN side SNS restart will stop answer on ALIVE and is sending NS STATUS
invalid protocol state.
BSS side SNS restart will send a SNS Size procedure to reset the state.
Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
---
M src/gb/gprs_ns2_vty.c
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/23184/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria, daniel.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 )
Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................
Patch Set 2:
(2 comments)
File src/gb/gprs_ns2_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/23184/comment/754332f0_48078885
PS2, Line 2073: restart sns
> I recommend concatenating these two words into 'restart-sns'.
Ack
https://gerrit.osmocom.org/c/libosmocore/+/23184/comment/e35fc6e5_ac120c4f
PS2, Line 2074: NS Entity ID (NSEI)\n
> "Persistent NS Entity", this is not the ID itself.
it's working for both persistent as not persistent. I don't understand what you mean here.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Mar 2022 14:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Leap_15.1_ARM/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 172s] checking for byteswap.h... yes
[ 172s] checking for an ANSI C-conforming const... yes
[ 172s] checking for inline... inline
[ 173s] checking for size_t... yes
[ 174s] checking whether time.h and sys/time.h may both be included... yes
[ 174s] checking whether byte ordering is bigendian... no
[ 175s] checking for libosmocore >= 1.6.0... no
[ 175s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met:
[ 175s]
[ 175s] Package 'libsctp', required by 'libosmocore', not found
[ 175s]
[ 175s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 175s] installed software in a non-standard prefix.
[ 175s]
[ 175s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 175s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 175s] See the pkg-config man page for more details.
[ 175s] error: Bad exit status from /var/tmp/rpm-tmp.nQ1vPw (%build)
[ 175s]
[ 175s]
[ 175s] RPM build errors:
[ 175s] Bad exit status from /var/tmp/rpm-tmp.nQ1vPw (%build)
[ 175s] ### VM INTERACTION START ###
[ 175s] [ 141.505254] sysrq: SysRq : Power Off
[ 175s] [ 141.518702] reboot: Power down
[ 175s] ### VM INTERACTION END ###
[ 175s]
[ 175s] obs-arm-6 failed "build osmo-trx.spec" at Fri Mar 25 11:29:42 UTC 2022.
[ 175s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-ggsn failed to build in openSUSE_Leap_15.1_ARM/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-ggsn
Last lines of build log:
[ 120s] checking for getopt_long... yes
[ 120s] checking whether build environment is sane... yes
[ 120s] checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
[ 120s] checking whether make sets $(MAKE)... yes
[ 120s] checking for style of include used by make... GNU
[ 120s] checking dependency style of gcc... none
[ 120s] checking for libosmocore >= 1.5.0... no
[ 120s] configure: error: Package requirements (libosmocore >= 1.5.0) were not met:
[ 120s]
[ 120s] Package 'libsctp', required by 'libosmocore', not found
[ 120s]
[ 120s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 120s] installed software in a non-standard prefix.
[ 120s]
[ 120s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 120s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 120s] See the pkg-config man page for more details.
[ 120s] error: Bad exit status from /var/tmp/rpm-tmp.M6Uoi0 (%build)
[ 120s]
[ 120s]
[ 120s] RPM build errors:
[ 120s] Bad exit status from /var/tmp/rpm-tmp.M6Uoi0 (%build)
[ 120s] ### VM INTERACTION START ###
[ 121s] [ 103.410595] sysrq: SysRq : Power Off
[ 121s] [ 103.412624] reboot: Power down
[ 121s] ### VM INTERACTION END ###
[ 121s]
[ 121s] armbuild01 failed "build osmo-ggsn.spec" at Fri Mar 25 11:23:37 UTC 2022.
[ 121s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)