- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req
by pespin 23 Apr '22

23 Apr '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 ) Change subject: bsc: Introduce test TC_paging_500req ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4f7185939c20804deef92f476ed19248ba885f29 Gerrit-Change-Number: 27890 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 22 Apr 2022 15:43:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24
by pespin 23 Apr '22

23 Apr '22

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: What about supporting both? https://github.com/riverrun/one_time_pass_ecto/pull/10/commits/822f0c8bffab… -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24
by fixeria 23 Apr '22

23 Apr '22

Attention is currently required from: laforge, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24
by daniel 23 Apr '22

23 Apr '22

Attention is currently required from: laforge, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:39:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Limit the fine tuning range
by tnt 23 Apr '22

23 Apr '22

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 ) Change subject: icE1usb fw/gpsdo: Limit the fine tuning range ...................................................................... icE1usb fw/gpsdo: Limit the fine tuning range Fine tuning has a limited tuning range. If at some point we hit the limits, we need to bit the bullet and try to 'transfer' some of that to the coarse range as best as we can. Hopefully we get it close enough to limit disruption. Note that this should really never happen because although it's limited, the tuning range should be good enough to absorb any reasonable temperature / aging variation once we have coarse tuned. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 057490f..c1df4b0 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -240,8 +240,23 @@ g_gpsdo.fine.div = 0; } - /* Apply value with a bias from long term accumulator */ + /* Compute value with a bias from long term accumulator */ tune = g_gpsdo.tune.fine - (g_gpsdo.fine.acc / 2); + + /* If fine tune is getting close to boundary, do our + * best to transfer part of it to coarse tuning */ + if ((g_gpsdo.tune.fine < 512) || (g_gpsdo.tune.fine > 3584)) + { + int coarse_adj = ((int)g_gpsdo.tune.fine - 2048) >> 6; + + g_gpsdo.tune.coarse += coarse_adj; + g_gpsdo.tune.fine -= coarse_adj << 6; + tune -= coarse_adj << 6; + + pdm_set(PDM_CLK_HI, true, g_gpsdo.tune.coarse, false); + } + + /* Apply fine */ pdm_set(PDM_CLK_LO, true, tune, false); /* Debug */ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 Gerrit-Change-Number: 27895 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Limit the fine tuning range
by tnt 23 Apr '22

23 Apr '22

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 ) Change subject: icE1usb fw/gpsdo: Limit the fine tuning range ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 Gerrit-Change-Number: 27895 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:36:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Attempt to recover from bad tuning
by tnt 23 Apr '22

23 Apr '22

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 ) Change subject: icE1usb fw/gpsdo: Attempt to recover from bad tuning ...................................................................... icE1usb fw/gpsdo: Attempt to recover from bad tuning If we're in hold over mode and getting a bunch of invalid frequency measurement despite a good fix, then we most likely ended up on a bad tuning value and we need to recover by starting from scratch. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: If8503a3eaf695e02a0ef0a3b6536de985d247c20 --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index c94a5ed..057490f 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -280,6 +280,7 @@ if (!gps_has_valid_fix()) { /* No GPS fix, go to hold-over */ g_gpsdo.state = STATE_HOLD_OVER; + g_gpsdo.meas.invalid = 0; return; } @@ -293,10 +294,22 @@ return; } } else { - /* Count invalid measurements and if too many of - * them, we go back to hold-over */ - if (++g_gpsdo.meas.invalid >= MAX_INVALID) - g_gpsdo.state = STATE_HOLD_OVER; + /* Count invalid measurements */ + if (++g_gpsdo.meas.invalid >= MAX_INVALID) { + if (g_gpsdo.state != STATE_HOLD_OVER) { + /* We go back to hold-over */ + g_gpsdo.state = STATE_HOLD_OVER; + g_gpsdo.meas.invalid = 0; + } else { + /* We're in hold-over, with valid fix, and + * still get a bunch of invalid. Reset tuning */ + g_gpsdo.tune.coarse = 2048; + g_gpsdo.tune.fine = 2048; + + pdm_set(PDM_CLK_HI, true, g_gpsdo.tune.coarse, false); + pdm_set(PDM_CLK_LO, true, g_gpsdo.tune.fine, false); + } + } /* In all cases, invalid measurements are not used */ return; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: If8503a3eaf695e02a0ef0a3b6536de985d247c20 Gerrit-Change-Number: 27894 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Attempt to recover from bad tuning
by tnt 23 Apr '22

23 Apr '22

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 ) Change subject: icE1usb fw/gpsdo: Attempt to recover from bad tuning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: If8503a3eaf695e02a0ef0a3b6536de985d247c20 Gerrit-Change-Number: 27894 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry
by tnt 23 Apr '22

23 Apr '22

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 ) Change subject: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry ...................................................................... icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 7e3682f..c94a5ed 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -145,6 +145,11 @@ static void _gpsdo_coarse_start(void) { + /* Debug */ +#ifdef GPSDO_DEBUG + printf("[+] GPSDO Coarse Start: tune=%d:%d\n", g_gpsdo.tune.coarse, g_gpsdo.tune.fine); +#endif + /* Set the state */ g_gpsdo.state = STATE_TUNE_COARSE; @@ -165,6 +170,10 @@ static void _gpsdo_fine_start(void) { +#ifdef GPSDO_DEBUG + printf("[+] GPSDO Fine Start\n"); +#endif + /* Set the state */ g_gpsdo.state = STATE_TUNE_FINE; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f Gerrit-Change-Number: 27893 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry
by tnt 23 Apr '22

23 Apr '22

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 ) Change subject: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f Gerrit-Change-Number: 27893 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:34:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log