laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27907 )
Change subject: debian-buster-jenkins: install libelf-dev
......................................................................
debian-buster-jenkins: install libelf-dev
Add libelf-dev to be able to build kernel modules with
defconfig_x86_64.
This is an update to commit d6c5c7a0341c966ddef235a5d6e00a536c1a857c,
which should have not just modified the stretch but also the buster
Docker image
Change-Id: I4c442d86688278ff634a286b98637189eef88bfb
Related: OS#5407
---
M debian-buster-jenkins/Dockerfile
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile
index 0ea81fe..6bbd389 100644
--- a/debian-buster-jenkins/Dockerfile
+++ b/debian-buster-jenkins/Dockerfile
@@ -56,6 +56,7 @@
libcsv-dev \
libdbd-sqlite3 \
libdbi-dev \
+ libelf-dev \
libffi-dev \
libfftw3-dev \
libgmp-dev \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27907
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I4c442d86688278ff634a286b98637189eef88bfb
Gerrit-Change-Number: 27907
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27907 )
Change subject: debian-buster-jenkins: install libelf-dev
......................................................................
debian-buster-jenkins: install libelf-dev
Add libelf-dev to be able to build kernel modules with
defconfig_x86_64.
This is an update to commit d6c5c7a0341c966ddef235a5d6e00a536c1a857c,
which should have not just modified the stretch but also the buster
Docker image
Change-Id: I4c442d86688278ff634a286b98637189eef88bfb
Related: OS#5407
---
M debian-buster-jenkins/Dockerfile
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/07/27907/1
diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile
index 0ea81fe..6bbd389 100644
--- a/debian-buster-jenkins/Dockerfile
+++ b/debian-buster-jenkins/Dockerfile
@@ -56,6 +56,7 @@
libcsv-dev \
libdbd-sqlite3 \
libdbi-dev \
+ libelf-dev \
libffi-dev \
libfftw3-dev \
libgmp-dev \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27907
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I4c442d86688278ff634a286b98637189eef88bfb
Gerrit-Change-Number: 27907
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27904 )
Change subject: emerg call deny: log on LOGL_ERROR
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
A spec. violation from the MS side does not look like an error condition to me... I would keep it on NOTICE.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27904
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec
Gerrit-Change-Number: 27904
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Apr 2022 23:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27903 )
Change subject: emerg call deny: do not dispatch dtap
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/gsm_04_08_rr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27903/comment/9ddbe8b4_dbdb0ba1
PS1, Line 1077: /* fall through */
I see no change here: 'break' generally moves the execution flow out of the switch statement (unless it's part of an inner switch statement or a loop). Neither I see inner switch statements here, nor any loops. So if we break, we don't fall through. Am I missing something?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I065953f0380e142824ba30a842c86f9c598f89fe
Gerrit-Change-Number: 27903
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Apr 2022 23:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment