- gerrit-log - lists.osmocom.org

Change in pysim[master]: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a min length
by laforge 11 Jun '22

11 Jun '22

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28185 ) Change subject: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a min length ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File pySim/construct.py: https://gerrit.osmocom.org/c/pysim/+/28185/comment/b7c90ece_569701a7 PS5, Line 241: if nbytes < minlen: > I do not insist on using min() here, but could you please explain (or give an example) what's wrong […] I really don't think either of you needs to spend any more time on this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief113ce8fe3bcae2c9fb2ff4138df9ccf98d26ff Gerrit-Change-Number: 28185 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Jun 2022 06:04:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64
by OBS Notification 11 Jun '22

11 Jun '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 163s] [437/499] installing libosmocore-dev-1.6.0.124.0cdd0.202206110026 [ 163s] [438/499] installing libpangoft2-1.0-0-1.50.7+ds-1 [ 163s] [439/499] installing texlive-base-2022.20220405-2 [ 166s] mktexlsr: Updating /var/lib/texmf/ls-R-TEXLIVEDIST... [ 166s] mktexlsr: Updating /var/lib/texmf/ls-R-TEXMFMAIN... [ 166s] mktexlsr: Updating /var/lib/texmf/ls-R... [ 166s] mktexlsr: Done. [ 167s] tl-paper: setting paper size for dvips to a4: /var/lib/texmf/dvips/config/config-paper.ps [ 167s] tl-paper: setting paper size for dvipdfmx to a4: /var/lib/texmf/dvipdfmx/dvipdfmx-paper.cfg [ 168s] tl-paper: setting paper size for xdvi to a4: /var/lib/texmf/xdvi/XDvi-paper [ 168s] tl-paper: setting paper size for pdftex to a4: /var/lib/texmf/tex/generic/tex-ini-files/pdftexconfig.tex [ 170s] [440/499] installing debhelper-13.7.1 [ 170s] [441/499] installing systemd-250.4-1 [ 171s] Created symlink /etc/systemd/system/getty.target.wants/getty(a)tty1.service -> /lib/systemd/system/getty@.service. [ 171s] Created symlink /etc/systemd/system/multi-user.target.wants/remote-fs.target -> /lib/systemd/system/remote-fs.target. [ 171s] Created symlink /etc/systemd/system/sysinit.target.wants/systemd-pstore.service -> /lib/systemd/system/systemd-pstore.service. [ 171s] systemd-machine-id-setup: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory [ 171s] dpkg: error processing package systemd (--install): [ 171s] installed systemd package post-installation script subprocess returned error exit status 127 [ 171s] Errors were encountered while processing: [ 171s] systemd [ 171s] exit ... [ 171s] ### VM INTERACTION START ### [ 171s] [ 128.242352][ T1] sysrq: Power Off [ 171s] [ 128.248483][ T16] reboot: Power down [ 172s] ### VM INTERACTION END ### [ 172s] [ 172s] lamb56 failed "build osmo-bsc_1.8.0.212.927c0.202206110026.dsc" at Sat Jun 11 02:49:18 UTC 2022. [ 172s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix IPA_CFG_PORT handling several connections
by pespin 10 Jun '22

10 Jun '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28267 ) Change subject: bsc: Fix IPA_CFG_PORT handling several connections ...................................................................... bsc: Fix IPA_CFG_PORT handling several connections Recent commit changing the layout of bts/trx port config made IPA_CFG_PORT be connected severa times when calling f_ipa_rsl_start() for each BTS/TRX. Let's have separate ports per BTS/TRX as done in other ports in the test_CT component. This avoid this error when calling f_ipa_rsl_stop(): """ Dynamic test case error: Port IPA_CFG_PORT has more than one active connections. Message can be sent on it only with explicit addressing. """ Change-Id: I916186c87c398ebb2d7f82f73b94de75034e346d --- M bsc/BSC_Tests.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b445709..8a7d465 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -612,8 +612,8 @@ port IPA_CODEC_PT IPA; /* Required for compilation of TC_rsl_unknown_unit_id() */ /* CTRL muxed over IPA in SCCPlite conn BSC<->MSC (or BSC-NAT) */ port IPA_CTRL_PT SCCPLITE_IPA_CTRL; - /* Configure/manage IPA_Emulation: */ - port IPA_CFG_PT IPA_CFG_PORT; + /* Configure/manage IPA_Emulation per-BTS/TRX port: */ + port IPA_CFG_PT IPA_CFG_PORT[NUM_BTS][NUM_TRX]; var MGCP_Emulation_CT vc_MGCP; port TELNETasp_PT BSCVTY; @@ -953,7 +953,7 @@ } map(clnt.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); - connect(clnt.vc_IPA:CFG_PORT, self:IPA_CFG_PORT); + connect(clnt.vc_IPA:CFG_PORT, self:IPA_CFG_PORT[idx.bts][idx.trx]); if (handler_mode) { connect(clnt.vc_IPA:IPA_RSL_PORT, clnt.vc_RSL:IPA_PT); } else { @@ -982,7 +982,7 @@ } } -function f_ipa_rsl_stop(inout IPA_Client clnt) runs on test_CT { +function f_ipa_rsl_stop(inout IPA_Client clnt, BtsTrxIdx idx := {0, 0}) runs on test_CT { var IPL4asp_Types.Result res := { errorCode := omit, connId := omit, @@ -997,7 +997,7 @@ /* Alive components don't finish sockets (TCP FIN) when they are * stopped. Hence, we need to manually call close() on them to make sure * the IUT knows about it. */ - f_ipa_cfg_disconnect(IPA_CFG_PORT, res); + f_ipa_cfg_disconnect(IPA_CFG_PORT[idx.bts][idx.trx], res); clnt.vc_IPA.stop; if (isbound(clnt.vc_RSL)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I916186c87c398ebb2d7f82f73b94de75034e346d Gerrit-Change-Number: 28267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix IPA_CFG_PORT handling several connections
by fixeria 10 Jun '22

10 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28267 ) Change subject: bsc: Fix IPA_CFG_PORT handling several connections ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I916186c87c398ebb2d7f82f73b94de75034e346d Gerrit-Change-Number: 28267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 17:10:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a min length
by fixeria 10 Jun '22

10 Jun '22

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28185 ) Change subject: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a min length ...................................................................... Patch Set 9: (1 comment) File pySim/construct.py: https://gerrit.osmocom.org/c/pysim/+/28185/comment/cde634f3_72ba9412 PS5, Line 241: if nbytes < minlen: > Done I do not insist on using min() here, but could you please explain (or give an example) what's wrong with using it? What exactly behaves differently? Just curious. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief113ce8fe3bcae2c9fb2ff4138df9ccf98d26ff Gerrit-Change-Number: 28185 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 17:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix IPA_CFG_PORT handling several connections
by pespin 10 Jun '22

10 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28267 ) Change subject: bsc: Fix IPA_CFG_PORT handling several connections ...................................................................... bsc: Fix IPA_CFG_PORT handling several connections Recent commit changing the layout of bts/trx port config made IPA_CFG_PORT be connected severa times when calling f_ipa_rsl_start() for each BTS/TRX. Let's have separate ports per BTS/TRX as done in other ports in the test_CT component. This avoid this error when calling f_ipa_rsl_stop(): """ Dynamic test case error: Port IPA_CFG_PORT has more than one active connections. Message can be sent on it only with explicit addressing. """ Change-Id: I916186c87c398ebb2d7f82f73b94de75034e346d --- M bsc/BSC_Tests.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/28267/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b445709..8a7d465 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -612,8 +612,8 @@ port IPA_CODEC_PT IPA; /* Required for compilation of TC_rsl_unknown_unit_id() */ /* CTRL muxed over IPA in SCCPlite conn BSC<->MSC (or BSC-NAT) */ port IPA_CTRL_PT SCCPLITE_IPA_CTRL; - /* Configure/manage IPA_Emulation: */ - port IPA_CFG_PT IPA_CFG_PORT; + /* Configure/manage IPA_Emulation per-BTS/TRX port: */ + port IPA_CFG_PT IPA_CFG_PORT[NUM_BTS][NUM_TRX]; var MGCP_Emulation_CT vc_MGCP; port TELNETasp_PT BSCVTY; @@ -953,7 +953,7 @@ } map(clnt.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); - connect(clnt.vc_IPA:CFG_PORT, self:IPA_CFG_PORT); + connect(clnt.vc_IPA:CFG_PORT, self:IPA_CFG_PORT[idx.bts][idx.trx]); if (handler_mode) { connect(clnt.vc_IPA:IPA_RSL_PORT, clnt.vc_RSL:IPA_PT); } else { @@ -982,7 +982,7 @@ } } -function f_ipa_rsl_stop(inout IPA_Client clnt) runs on test_CT { +function f_ipa_rsl_stop(inout IPA_Client clnt, BtsTrxIdx idx := {0, 0}) runs on test_CT { var IPL4asp_Types.Result res := { errorCode := omit, connId := omit, @@ -997,7 +997,7 @@ /* Alive components don't finish sockets (TCP FIN) when they are * stopped. Hence, we need to manually call close() on them to make sure * the IUT knows about it. */ - f_ipa_cfg_disconnect(IPA_CFG_PORT, res); + f_ipa_cfg_disconnect(IPA_CFG_PORT[idx.bts][idx.trx], res); clnt.vc_IPA.stop; if (isbound(clnt.vc_RSL)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I916186c87c398ebb2d7f82f73b94de75034e346d Gerrit-Change-Number: 28267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by pespin 10 Jun '22

10 Jun '22

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > i kept it as a completely separate lib from the start, because i think it has significant advantages […] You can create it locally and push it on monday when he's back :) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 Jun 2022 16:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by neels 10 Jun '22

10 Jun '22

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > It really depends on whether libosmo-gtlv is used internally only n lbosmo-pfcp or publically expose […] i kept it as a completely separate lib from the start, because i think it has significant advantages over the osmocom/tlv/ implementation... if we had nothing else to do it could be fun to re-implement all of RSL, BSSMAP etc using gtlv. So I'm going to libosmocore.git for libosmo-gtlv. Because i want to use libosmo-pfcp from osmo-hnbgw, i'd move that to libosmo-pfcp.git now, but i think i need to wait for Harald to create it first? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 16:21:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: ansible: get OBS pub key from proper URL
by pespin 10 Jun '22

10 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28266 ) Change subject: ansible: get OBS pub key from proper URL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I630654ade0edddd23f9fe7c578d1f329f5f49603 Gerrit-Change-Number: 28266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 14:34:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: repo-install-test: get OBS pub key from proper URL
by pespin 10 Jun '22

10 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28265 ) Change subject: repo-install-test: get OBS pub key from proper URL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idd0fb6e07cba959a36269244b0c7b5c62aaffeee Gerrit-Change-Number: 28265 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 14:34:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log