Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28264 )
Change subject: move new_transp_layer_addr to public API
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Icc61620b4d11c4ba6823b40abc7c300f0533c058
Gerrit-Change-Number: 28264
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Jun 2022 19:09:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: k_o_.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28248 )
Change subject: APDU parsing support for GlobalPlatform
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> I think it is related the the Android carrier privileges using the GlobalPlatform access rules which […]
I don't think there really is any way to know the "direction" of the data phase without knowing the related command. Both parties (card and phone) must have a-priori knowledge on which of the two parties sends after the 5-byte TPDU header...
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib734fc852e7b63b9efdc414adccbd796a572eb55
Gerrit-Change-Number: 28248
Gerrit-PatchSet: 1
Gerrit-Owner: k_o_ <wider.stand(a)gmx.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: k_o_ <wider.stand(a)gmx.de>
Gerrit-Comment-Date: Mon, 13 Jun 2022 19:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: k_o_ <wider.stand(a)gmx.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28265 )
Change subject: repo-install-test: get OBS pub key from proper URL
......................................................................
repo-install-test: get OBS pub key from proper URL
The public OBS key expired on 2022-05-22 and was replaced with a key
that was only shortly valid until 2022-06-08. Shortly after it was
replaced with a key that is valid longer, until 2024-08-02.
On 2022-06-09, one of the osmocom-repo-install tests started failing.
For some reason, the key in the latest/Debian_10 directory was not
updated to the latest one:
https://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_…
Since the key is the same for all of network:osmocom, adjust the
function to download it from a place that the OBS web UI links to when
attempting to download the public GPG key.
I guess the latest/Debian_10/Release.key will get updated once making a
new release and updating the packages in the repository. But sinc
there's a lot of other tasks to do, just use this practical solution for
now.
Change-Id: Idd0fb6e07cba959a36269244b0c7b5c62aaffeee
---
M scripts/repo-install-test/run-inside-docker.sh
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/scripts/repo-install-test/run-inside-docker.sh b/scripts/repo-install-test/run-inside-docker.sh
index e44c609..933adef 100755
--- a/scripts/repo-install-test/run-inside-docker.sh
+++ b/scripts/repo-install-test/run-inside-docker.sh
@@ -100,7 +100,6 @@
configure_osmocom_repo_debian() {
local proj="$1"
local obs_repo="download.opensuse.org/repositories/$(proj_with_slashes "$proj")/$DISTRO_OBSDIR/"
- local release_key="/var/cache/apt/${proj}_Release.key"
echo "Configuring Osmocom repository"
@@ -108,9 +107,9 @@
if ! [ -e "$release_key" ]; then
apt-get update
apt install -y wget
- wget -O "$release_key" "https://$obs_repo/Release.key"
+ wget -O /tmp/Release.key "https://build.opensuse.org/projects/network:osmocom/public_key"
fi
- apt-key add "$release_key"
+ apt-key add /tmp/Release.key
echo "deb http://$obs_repo ./" > "/etc/apt/sources.list.d/$proj.list"
apt-get update
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Idd0fb6e07cba959a36269244b0c7b5c62aaffeee
Gerrit-Change-Number: 28265
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28272 )
Change subject: iuup: Check for IuUP Initialization retrans
......................................................................
iuup: Check for IuUP Initialization retrans
Since libosmocore.git Change-Id
I5cb740702805693cc7f0a550e2e093f9bfdd507c, the IuUP stack can send INIT
event more than once, it sends one each time an IuUP Initialization
message is received.
This is done since potentially a peer could send an Initialization
message at any time with a different subflow size configuration. So
ideally we should update all osmo-mgw state regarding codecs, and
forward the Init starting the procedure on the other conn of the
endpoint.
However, this scenario is most probably not going to happen right now
and it would be a lot of work to implement and test,
and subsequent INITs we received will almost surely come from
retransmissions of the initial Initialization message, which means
content will not really change.
Hence, it makes sense to simply drop the receive message (the IuUP stack
already takes care of re-ACKing it) and let the endpoint state continue
with its ongoing procedures.
Related: SYS#4705
Change-Id: Ib97bc6f57d265622e24a776b96f0a82c25d33d39
---
M src/libosmo-mgcp/mgcp_iuup.c
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/libosmo-mgcp/mgcp_iuup.c b/src/libosmo-mgcp/mgcp_iuup.c
index 120b330..142b002 100644
--- a/src/libosmo-mgcp/mgcp_iuup.c
+++ b/src/libosmo-mgcp/mgcp_iuup.c
@@ -365,13 +365,22 @@
int rc = 0;
struct msgb *msg;
- /* Find RFCI containing NO_DATA: */
- conn_rtp_src->iuup.rfci_id_no_data = _find_rfci_no_data(irp);
+ if (conn_rtp_src->iuup.init_ind) {
+ /* We received more than one IuUP Initialization. It's probably
+ * a retransmission, so simply ignore it (lower layers take care
+ * of ACKing it). */
+ LOGPCONN(conn_rtp_src->conn, DRTP, LOGL_INFO,
+ "Ignoring potential IuUP Initialization retrans\n");
+ return 0;
+ }
msg = msgb_copy_c(conn_rtp_src->conn, irp->oph.msg, "iuup-init-copy");
conn_rtp_src->iuup.init_ind = (struct osmo_iuup_rnl_prim *)msgb_data(msg);
conn_rtp_src->iuup.init_ind->oph.msg = msg;
+ /* Find RFCI containing NO_DATA: */
+ conn_rtp_src->iuup.rfci_id_no_data = _find_rfci_no_data(irp);
+
conn_dst = _find_dst_conn(conn_rtp_src->conn);
/* If not yet there, peer will potentially be IuUP-Initialized later
* when we attempt to bridge audio towards it. See bridge_iuup_to_iuup_peer() */
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28272
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib97bc6f57d265622e24a776b96f0a82c25d33d39
Gerrit-Change-Number: 28272
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged