Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28649 )
Change subject: fsm: fix state_chg(): pass microseconds to osmo_timer_schedule()
......................................................................
Patch Set 1:
(1 comment)
File src/fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/28649/comment/e6e6bb8f_1ce47803
PS1, Line 691: timeout_ms % 1000
> I wouldn't be sure of operator precendence here without looking at the C standard and would put (tim […]
Agree
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib0b6c3bdb56e4279df9e5ba7db16841645c452aa
Gerrit-Change-Number: 28649
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28632 )
Change subject: move EF_UServiceTable from ts_31_102 to ts_31_102_telecom
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/28632/comment/e24e217a_a2889048
PS1, Line 10: avoid cyclic imports
> it is. We are and have always been using selective imports between ts_51_011.py and ts_31_102. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cd6ab795bfd92f845eb943679a3d6302f1003ce
Gerrit-Change-Number: 28632
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 07:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28649 )
Change subject: fsm: fix state_chg(): pass microseconds to osmo_timer_schedule()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/28649/comment/59ceb06c_1cdf13c8
PS1, Line 691: timeout_ms % 1000
I wouldn't be sure of operator precendence here without looking at the C standard and would put (timeout_ms % 1000) in parenthesis.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib0b6c3bdb56e4279df9e5ba7db16841645c452aa
Gerrit-Change-Number: 28649
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 07:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment