- gerrit-log - lists.osmocom.org

Change in ...osmo_dia2gsup[master]: add rebar.lock to define known working dependencies
by pespin 19 Jul '22

19 Jul '22

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28650 ) Change subject: add rebar.lock to define known working dependencies ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: why is this needed in the git repo? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I40660b23cee04ef2b4afbca34522a42a4b057e2e Gerrit-Change-Number: 28650 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:52:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: getsockopt ret socklen_t is unsigned
by pespin 19 Jul '22

19 Jul '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28647 ) Change subject: stream: getsockopt ret socklen_t is unsigned ...................................................................... stream: getsockopt ret socklen_t is unsigned Found out by following gcc warning: """ libosmo-netif/src/stream.c:147:11: warning: argument to variable-length array may be too large due to conversion from ‘int’ to ‘unsigned int’ [-Wvla-larger-than=] 147 | uint8_t buf[sctp_sockopt_event_subscribe_size]; | ^~~ """ Change-Id: I181ae5c0480788fc96abd2bb1edf003244884c8f --- M src/stream.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/stream.c b/src/stream.c index e6b731c..cdd0eae 100644 --- a/src/stream.c +++ b/src/stream.c @@ -87,7 +87,7 @@ return -1; } -static int sctp_sockopt_event_subscribe_size = 0; +static unsigned int sctp_sockopt_event_subscribe_size = 0; static int determine_sctp_sockopt_event_subscribe_size(void) { @@ -96,7 +96,7 @@ int sd, rc; /* only do this once */ - if (sctp_sockopt_event_subscribe_size != 0) + if (sctp_sockopt_event_subscribe_size > 0) return 0; sd = socket(AF_INET, SOCK_STREAM, IPPROTO_SCTP); @@ -108,7 +108,7 @@ if (rc < 0) return rc; - sctp_sockopt_event_subscribe_size = buf_len; + sctp_sockopt_event_subscribe_size = (unsigned int)buf_len; LOGP(DLINP, LOGL_INFO, "sizes of 'struct sctp_event_subscribe': compile-time %zu, kernel: %u\n", sizeof(struct sctp_event_subscribe), sctp_sockopt_event_subscribe_size); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I181ae5c0480788fc96abd2bb1edf003244884c8f Gerrit-Change-Number: 28647 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-netif[master]: stream: getsockopt ret socklen_t is unsigned
by pespin 19 Jul '22

19 Jul '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28647 ) Change subject: stream: getsockopt ret socklen_t is unsigned ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I181ae5c0480788fc96abd2bb1edf003244884c8f Gerrit-Change-Number: 28647 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:51:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: debian: add generate_build_dep.sh to vendor erlang dependencies
by osmith 19 Jul '22

19 Jul '22

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653 ) Change subject: debian: add generate_build_dep.sh to vendor erlang dependencies ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653/comment/fb1c5a7b_… PS1, Line 8: the plan is to run this while generating source packages in the jenkins jobs, I'd mention it here. File contrib/generate_build_dep.sh: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653/comment/44e7df20_… PS1, Line 1: #!/bin/sh #!/bin/sh -e so it fails if one of the commands fail? https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653/comment/eb2e4eb8_… PS1, Line 10: I'd add "set -x" here so we see the commands, in case one fails -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I22041887fd1b72ea328605d18801d412b86bfc9c Gerrit-Change-Number: 28653 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:46:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: debian: rework packaging
by osmith 19 Jul '22

19 Jul '22

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652 ) Change subject: debian: rework packaging ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Thanks, this is much cleaner! LGTM besides the "rm -rf" command File debian/osmo-diameter2gsup.install: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652/comment/5f2a65c9_… PS1, Line 2: /_build/default/bin/osmo-dia2gsup /usr/bin/ does it still start with the systemd service? I'm not familiar at all with erlang, I though the other libraries were needed at runtime File debian/rules: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652/comment/3c0c5986_… PS1, Line 18: _lib _lib doesn't get created anymore: rm -rf _build -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I40add168875de87ef0cc62deeb5377d2ce080e45 Gerrit-Change-Number: 28652 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:43:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: debian: add missing Build-Depends debhelper
by osmith 19 Jul '22

19 Jul '22

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28651 ) Change subject: debian: add missing Build-Depends debhelper ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1b5774983d705c54c909823da329068a7aa0a9a8 Gerrit-Change-Number: 28651 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:37:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: add rebar.lock to define known working dependencies
by osmith 19 Jul '22

19 Jul '22

Attention is currently required from: pespin, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28650 ) Change subject: add rebar.lock to define known working dependencies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I40660b23cee04ef2b4afbca34522a42a4b057e2e Gerrit-Change-Number: 28650 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: debian: add generate_build_dep.sh to vendor erlang dependencies
by lynxis lazus 19 Jul '22

19 Jul '22

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653 ) Change subject: debian: add generate_build_dep.sh to vendor erlang dependencies ...................................................................... debian: add generate_build_dep.sh to vendor erlang dependencies Change-Id: I22041887fd1b72ea328605d18801d412b86bfc9c --- A contrib/generate_build_dep.sh M debian/rules 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/53/28653/1 diff --git a/contrib/generate_build_dep.sh b/contrib/generate_build_dep.sh new file mode 100755 index 0000000..dec814f --- /dev/null +++ b/contrib/generate_build_dep.sh @@ -0,0 +1,16 @@ +#!/bin/sh + +# execute the script from the top dir of this repository to generate +# a build_dep.tar.gz for building with debian/OBS + +if [ ! -e rebar.config ] ; then + echo "Please execute $0 from the top directory of the osmo_dia2gsup directory" + exit 1 +fi + +rm -rf _checkouts _build +rebar3 get-deps +mkdir _checkouts +mv ./_build/default/lib/* _checkouts/ +mv ./_build/default/plugins/* _checkouts/ +tar czf build_dep.tar.gz ./_checkouts diff --git a/debian/rules b/debian/rules index 557601b..4648bb3 100755 --- a/debian/rules +++ b/debian/rules @@ -9,10 +9,11 @@ override_dh_auto_build: dh_auto_build + if [ -e build_dep.tar.gz ] ; then tar xzf ./build_dep.tar.gz ; fi rebar3 compile rebar3 escriptize rebar3 eunit override_dh_clean: dh_clean - rm -rf _build _lib + rm -rf _build _lib _checkouts -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I22041887fd1b72ea328605d18801d412b86bfc9c Gerrit-Change-Number: 28653 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

Change in ...osmo_dia2gsup[master]: add rebar.lock to define known working dependencies
by lynxis lazus 19 Jul '22

19 Jul '22

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28650 ) Change subject: add rebar.lock to define known working dependencies ...................................................................... add rebar.lock to define known working dependencies The rebar.lock contains the last known working state of all dependencies with exact version numbers. rebar.config only holds the minimal dependencies (package x version >=2.0.0) Change-Id: I40660b23cee04ef2b4afbca34522a42a4b057e2e --- M .gitignore A rebar.lock 2 files changed, 35 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/50/28650/1 diff --git a/.gitignore b/.gitignore index 0f543cd..ead618a 100644 --- a/.gitignore +++ b/.gitignore @@ -2,7 +2,6 @@ include/ log/ -rebar.lock *.beam erl_crash.dump diff --git a/rebar.lock b/rebar.lock new file mode 100644 index 0000000..5079329 --- /dev/null +++ b/rebar.lock @@ -0,0 +1,35 @@ +{"1.2.0", +[{<<"epcap">>, + {git,"https://github.com/msantos/epcap", + {ref,"8328f8cae4efdeb94642f3b406225a2fa03a5cca"}}, + 1}, + {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, + {<<"lager">>, + {git,"https://github.com/erlang-lager/lager", + {ref,"c5447d2d85a0d446d41a79bffe0a6a66bd50c901"}}, + 0}, + {<<"osmo_gsup">>, + {git,"https://gitea.osmocom.org/erlang/osmo_gsup", + {ref,"ee15ee2b44f4a57c57831393d1fed2dc215d36e4"}}, + 0}, + {<<"osmo_ss7">>, + {git,"https://gitea.osmocom.org/erlang/osmo_ss7", + {ref,"3c6cdc5a53c4a5ec1aff417f2cbfaa9449004ee6"}}, + 0}, + {<<"parse_trans">>, + {git,"https://github.com/uwiger/parse_trans", + {ref,"d443908e0a8e3842c4763cefd4b37457b892c121"}}, + 1}, + {<<"pkt">>, + {git,"https://github.com/msantos/pkt", + {ref,"67a4a14f596fded5ad5f2d8f94318faa8ad2c288"}}, + 1}, + {<<"setup">>,{pkg,<<"setup">>,<<"2.0.2">>},0}]}. +[ +{pkg_hash,[ + {<<"goldrush">>, <<"F06E5D5F1277DA5C413E84D5A2924174182FB108DABB39D5EC548B27424CD106">>}, + {<<"setup">>, <<"1203F4CDA11306C2E34434244576DED0A7BBFB0908D9A572356C809BD0CDF085">>}]}, +{pkg_hash_ext,[ + {<<"goldrush">>, <<"99CB4128CFFCB3227581E5D4D803D5413FA643F4EB96523F77D9E6937D994CEB">>}, + {<<"setup">>, <<"7D6AAF5281D0B0C40980E128F9DC410DACD03799A8577201D4C8B43E7F97509A">>}]} +]. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I40660b23cee04ef2b4afbca34522a42a4b057e2e Gerrit-Change-Number: 28650 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

Change in ...osmo_dia2gsup[master]: debian: add missing Build-Depends debhelper
by lynxis lazus 19 Jul '22

19 Jul '22

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28651 ) Change subject: debian: add missing Build-Depends debhelper ...................................................................... debian: add missing Build-Depends debhelper Change-Id: I1b5774983d705c54c909823da329068a7aa0a9a8 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/51/28651/1 diff --git a/debian/control b/debian/control index 7d5b6a7..6698f59 100644 --- a/debian/control +++ b/debian/control @@ -5,6 +5,7 @@ Build-Depends: erlang-nox, libpcap-dev, rebar3, + debhelper Standards-Version: 4.5.0 Package: osmo-diameter2gsup -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1b5774983d705c54c909823da329068a7aa0a9a8 Gerrit-Change-Number: 28651 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log