- gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: cosmetic: s/app_evt_names/trxcon_fsm_event_names/
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28666 ) Change subject: trxcon: cosmetic: s/app_evt_names/trxcon_fsm_event_names/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iae0e753eddb7e0a1767e555653c9e9fdb58b7a7b Gerrit-Change-Number: 28666 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:15:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: use 'unsigned int tn' for timeslot number
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28665 ) Change subject: trxcon: cosmetic: use 'unsigned int tn' for timeslot number ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I wouldn't say this is cosmetic. Cosmetic would be changing the name of the variable (and even then I'm not sure it'd name it cosmetic). But here you are changing the type of a variable, so generated binary will probably change. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I93b5a91341e7f79ced0591e13250632ba5e5adef Gerrit-Change-Number: 28665 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:14:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: use 'unsigned int tn' for timeslot number
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28665 ) Change subject: trxcon: cosmetic: use 'unsigned int tn' for timeslot number ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I93b5a91341e7f79ced0591e13250632ba5e5adef Gerrit-Change-Number: 28665 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: use ARRAY_SIZE() whenever appropriate
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28664 ) Change subject: trxcon: cosmetic: use ARRAY_SIZE() whenever appropriate ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2a246bad8d11ed45fbf849de961713ab96907d83 Gerrit-Change-Number: 28664 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:13:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: s/ts_list/ts/ in struct l1sched_state
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28663 ) Change subject: trxcon: cosmetic: s/ts_list/ts/ in struct l1sched_state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I182b2a3ae1dcb1671aaaed9394cdfea34f7966a9 Gerrit-Change-Number: 28663 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:12:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: s/state/clck_state/ in struct l1sched_state
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28662 ) Change subject: trxcon: cosmetic: s/state/clck_state/ in struct l1sched_state ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: You could even do clk_st, but this way is always fine. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a1b971abaf06c0b1339895cf1748c5eb21d45e6 Gerrit-Change-Number: 28662 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:12:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: add missing #include for enum gsm_phys_chan_config
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28661 ) Change subject: trxcon: add missing #include for enum gsm_phys_chan_config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I850b9a5c34fc39829c464b563f1a78ef4e8a1dd5 Gerrit-Change-Number: 28661 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:11:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: tests/tdef: assert pointer returned by osmo_tdef_get_entry()
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28660 ) Change subject: tests/tdef: assert pointer returned by osmo_tdef_get_entry() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I96041eab2786d850a49cb38a60a368cef2e476d3 Gerrit-Change-Number: 28660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:08:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: tests/sbcap: fix wrong operator used in OSMO_ASSERT statement
by pespin 20 Jul '22

20 Jul '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28659 ) Change subject: tests/sbcap: fix wrong operator used in OSMO_ASSERT statement ...................................................................... tests/sbcap: fix wrong operator used in OSMO_ASSERT statement Change-Id: I6fe9080302166ad9bdc305eab736d51496dd1ff8 Related: CID#274972, CID#274971 --- M tests/sbcap/sbcap_test.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/sbcap/sbcap_test.c b/tests/sbcap/sbcap_test.c index 5c5a4b0..747d0b2 100644 --- a/tests/sbcap/sbcap_test.c +++ b/tests/sbcap/sbcap_test.c @@ -161,7 +161,7 @@ OSMO_ASSERT(rval.code == RC_OK); OSMO_ASSERT(pdu); - OSMO_ASSERT(pdu->present = SBcAP_SBC_AP_PDU_PR_successfulOutcome); + OSMO_ASSERT(pdu->present == SBcAP_SBC_AP_PDU_PR_successfulOutcome); OSMO_ASSERT(pdu->choice.successfulOutcome.procedureCode == SBcAP_ProcedureId_Write_Replace_Warning); OSMO_ASSERT(pdu->choice.successfulOutcome.criticality == SBcAP_Criticality_reject); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6fe9080302166ad9bdc305eab736d51496dd1ff8 Gerrit-Change-Number: 28659 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-cbc[master]: tests/sbcap: fix wrong operator used in OSMO_ASSERT statement
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28659 ) Change subject: tests/sbcap: fix wrong operator used in OSMO_ASSERT statement ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6fe9080302166ad9bdc305eab736d51496dd1ff8 Gerrit-Change-Number: 28659 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log