- gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: cosmetic: rename l1ctl_link.[ch] to l1ctl_server.[ch]
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28670 ) Change subject: trxcon: cosmetic: rename l1ctl_link.[ch] to l1ctl_server.[ch] ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I91149087bac6c745253d99deae2e32275b446a39 Gerrit-Change-Number: 28670 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: rework L1CTL socket API to support multiple clients
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 ) Change subject: trxcon: rework L1CTL socket API to support multiple clients ...................................................................... Patch Set 4: (3 comments) File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h: https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/8fc6275a_1fac43c7 PS4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */ Did you think about adding an .ops struct? https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/0d5c5e48_9b3d4d36 PS4, Line 35: struct llist_head list; document where is this item added to. struct l1ctl_server "clients" I guess? File src/host/trxcon/src/l1ctl_link.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/f7ea8b7d_116c40fb PS4, Line 110: static int l1ctl_client_conn_accept(struct osmo_fd *sfd, unsigned int flags) this new function name is misleading imho. I'd leave it as link or server, since you are operating on the fd of a server. l1ctl_server_conn_accept. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1cfc49f36ead6e2ba0a6110b0fb65c55412ef5e3 Gerrit-Change-Number: 28669 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:32:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: s/ts_list/ts/ in struct l1sched_state
by fixeria 20 Jul '22

20 Jul '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28663 ) Change subject: trxcon: cosmetic: s/ts_list/ts/ in struct l1sched_state ...................................................................... trxcon: cosmetic: s/ts_list/ts/ in struct l1sched_state Change-Id: I182b2a3ae1dcb1671aaaed9394cdfea34f7966a9 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c 4 files changed, 17 insertions(+), 17 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h b/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h index ae0bf9c..7b96f6d 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h @@ -363,7 +363,7 @@ /*! Frame callback */ void (*clock_cb)(struct l1sched_state *sched); /*! List of timeslots maintained by this scheduler */ - struct l1sched_ts *ts_list[TRX_TS_COUNT]; + struct l1sched_ts *ts[TRX_TS_COUNT]; /*! BSIC value learned from SCH bursts */ uint8_t bsic; }; diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c index 526772b..fb8a203 100644 --- a/src/host/trxcon/src/l1ctl.c +++ b/src/host/trxcon/src/l1ctl.c @@ -482,7 +482,7 @@ req->ccch_mode); /* TODO: add value-string for ccch_mode */ /* Make sure that TS0 is allocated and configured */ - ts = l1l->sched->ts_list[0]; + ts = l1l->sched->ts[0]; if (ts == NULL || ts->mf_layout == NULL) { LOGP(DL1C, LOGL_ERROR, "TS0 is not configured"); rc = -EINVAL; @@ -659,7 +659,7 @@ /* Configure requested TS */ rc = l1sched_configure_ts(l1l->sched, tn, config); - ts = l1l->sched->ts_list[tn]; + ts = l1l->sched->ts[tn]; if (rc) { rc = -EINVAL; goto exit; @@ -767,7 +767,7 @@ /* Iterate over timeslot list */ for (i = 0; i < TRX_TS_COUNT; i++) { /* Timeslot is not allocated */ - ts = l1l->sched->ts_list[i]; + ts = l1l->sched->ts[i]; if (ts == NULL) continue; @@ -813,7 +813,7 @@ tn = ul->chan_nr & 0x7; /* Make sure that required TS is allocated and configured */ - ts = l1l->sched->ts_list[tn]; + ts = l1l->sched->ts[tn]; if (ts == NULL || ts->mf_layout == NULL) { LOGP(DL1C, LOGL_ERROR, "TS %u is not configured\n", tn); rc = -EINVAL; diff --git a/src/host/trxcon/src/sched_prim.c b/src/host/trxcon/src/sched_prim.c index 17d0141..bcc9bce 100644 --- a/src/host/trxcon/src/sched_prim.c +++ b/src/host/trxcon/src/sched_prim.c @@ -98,7 +98,7 @@ tn = chan_nr & 0x7; /* Check whether required timeslot is allocated and configured */ - ts = sched->ts_list[tn]; + ts = sched->ts[tn]; if (ts == NULL || ts->mf_layout == NULL) { LOGP(DSCH, LOGL_ERROR, "Timeslot %u isn't configured\n", tn); return NULL; diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index 55b5ed5..556ebcc 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -78,7 +78,7 @@ }; /* Timeslot is not allocated */ - ts = sched->ts_list[i]; + ts = sched->ts[i]; if (ts == NULL) continue; @@ -208,18 +208,18 @@ struct l1sched_ts *l1sched_add_ts(struct l1sched_state *sched, int tn) { /* Make sure that ts isn't allocated yet */ - if (sched->ts_list[tn] != NULL) { + if (sched->ts[tn] != NULL) { LOGP(DSCH, LOGL_ERROR, "Timeslot #%u already allocated\n", tn); return NULL; } LOGP(DSCH, LOGL_NOTICE, "Add a new TDMA timeslot #%u\n", tn); - sched->ts_list[tn] = talloc_zero(sched, struct l1sched_ts); - sched->ts_list[tn]->sched = sched; - sched->ts_list[tn]->index = tn; + sched->ts[tn] = talloc_zero(sched, struct l1sched_ts); + sched->ts[tn]->sched = sched; + sched->ts[tn]->index = tn; - return sched->ts_list[tn]; + return sched->ts[tn]; } void l1sched_del_ts(struct l1sched_state *sched, int tn) @@ -228,7 +228,7 @@ struct l1sched_ts *ts; /* Find ts in list */ - ts = sched->ts_list[tn]; + ts = sched->ts[tn]; if (ts == NULL) return; @@ -247,7 +247,7 @@ l1sched_prim_flush_queue(&ts->tx_prims); /* Remove ts from list and free memory */ - sched->ts_list[tn] = NULL; + sched->ts[tn] = NULL; talloc_free(ts); /* Notify transceiver about that */ @@ -265,7 +265,7 @@ struct l1sched_ts *ts; /* Try to find specified ts */ - ts = sched->ts_list[tn]; + ts = sched->ts[tn]; if (ts != NULL) { /* Reconfiguration of existing one */ l1sched_reset_ts(sched, tn); @@ -327,7 +327,7 @@ struct l1sched_ts *ts; /* Try to find specified ts */ - ts = sched->ts_list[tn]; + ts = sched->ts[tn]; if (ts == NULL) return -EINVAL; @@ -719,7 +719,7 @@ int rc; /* Check whether required timeslot is allocated and configured */ - ts = sched->ts_list[tn]; + ts = sched->ts[tn]; if (ts == NULL || ts->mf_layout == NULL) { LOGP(DSCHD, LOGL_DEBUG, "TDMA timeslot #%u isn't configured, " "ignoring burst...\n", tn); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I182b2a3ae1dcb1671aaaed9394cdfea34f7966a9 Gerrit-Change-Number: 28663 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: use ARRAY_SIZE() whenever appropriate
by fixeria 20 Jul '22

20 Jul '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28664 ) Change subject: trxcon: cosmetic: use ARRAY_SIZE() whenever appropriate ...................................................................... trxcon: cosmetic: use ARRAY_SIZE() whenever appropriate Change-Id: I2a246bad8d11ed45fbf849de961713ab96907d83 --- M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_trx.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c index fb8a203..ef88cd9 100644 --- a/src/host/trxcon/src/l1ctl.c +++ b/src/host/trxcon/src/l1ctl.c @@ -765,7 +765,7 @@ "(tch_mode=%u, audio_mode=%u)\n", req->tch_mode, req->audio_mode); /* Iterate over timeslot list */ - for (i = 0; i < TRX_TS_COUNT; i++) { + for (i = 0; i < ARRAY_SIZE(l1l->sched->ts); i++) { /* Timeslot is not allocated */ ts = l1l->sched->ts[i]; if (ts == NULL) diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index 556ebcc..964c72f 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -69,7 +69,7 @@ sched->fn_counter_advance); /* Iterate over timeslot list */ - for (i = 0; i < TRX_TS_COUNT; i++) { + for (i = 0; i < ARRAY_SIZE(br); i++) { /* Initialize the buffer for this timeslot */ br[i] = (struct l1sched_burst_req) { .fn = fn, @@ -179,7 +179,7 @@ LOGP(DSCH, LOGL_NOTICE, "Shutdown scheduler\n"); /* Free all potentially allocated timeslots */ - for (i = 0; i < TRX_TS_COUNT; i++) + for (i = 0; i < ARRAY_SIZE(sched->ts); i++) l1sched_del_ts(sched, i); l1sched_clck_reset(sched); @@ -197,7 +197,7 @@ reset_clock ? "and clock counter" : ""); /* Free all potentially allocated timeslots */ - for (i = 0; i < TRX_TS_COUNT; i++) + for (i = 0; i < ARRAY_SIZE(sched->ts); i++) l1sched_del_ts(sched, i); /* Stop and reset clock counter if required */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2a246bad8d11ed45fbf849de961713ab96907d83 Gerrit-Change-Number: 28664 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: add missing #include for enum gsm_phys_chan_config
by fixeria 20 Jul '22

20 Jul '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28661 ) Change subject: trxcon: add missing #include for enum gsm_phys_chan_config ...................................................................... trxcon: add missing #include for enum gsm_phys_chan_config Change-Id: I850b9a5c34fc39829c464b563f1a78ef4e8a1dd5 --- M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h b/src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h index e336225..4a59d67 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h @@ -5,6 +5,8 @@ #include <osmocom/core/timer.h> #include <osmocom/core/fsm.h> +#include <osmocom/gsm/gsm_utils.h> + #define TRXC_BUF_SIZE 1024 #define TRXD_BUF_SIZE 512 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I850b9a5c34fc39829c464b563f1a78ef4e8a1dd5 Gerrit-Change-Number: 28661 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: cosmetic: s/state/clck_state/ in struct l1sched_state
by fixeria 20 Jul '22

20 Jul '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28662 ) Change subject: trxcon: cosmetic: s/state/clck_state/ in struct l1sched_state ...................................................................... trxcon: cosmetic: s/state/clck_state/ in struct l1sched_state Change-Id: I8a1b971abaf06c0b1339895cf1748c5eb21d45e6 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h M src/host/trxcon/src/sched_clck.c 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h b/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h index 7cdb043..ae0bf9c 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h @@ -349,7 +349,7 @@ /*! One scheduler instance */ struct l1sched_state { /*! Clock state */ - enum l1sched_clck_state state; + enum l1sched_clck_state clck_state; /*! Local clock source */ struct timespec clock; /*! Count of processed frames */ diff --git a/src/host/trxcon/src/sched_clck.c b/src/host/trxcon/src/sched_clck.c index 5fb8d62..9c77382 100644 --- a/src/host/trxcon/src/sched_clck.c +++ b/src/host/trxcon/src/sched_clck.c @@ -55,7 +55,7 @@ /* Check if transceiver is still alive */ if (sched->fn_counter_lost++ == TRX_LOSS_FRAMES) { LOGP(DSCH, LOGL_DEBUG, "No more clock from transceiver\n"); - sched->state = L1SCHED_CLCK_ST_WAIT; + sched->clck_state = L1SCHED_CLCK_ST_WAIT; return; } @@ -72,7 +72,7 @@ LOGP(DSCH, LOGL_NOTICE, "PC clock skew: " "elapsed uS %" PRId64 "\n", elapsed_us); - sched->state = L1SCHED_CLCK_ST_WAIT; + sched->clck_state = L1SCHED_CLCK_ST_WAIT; return; } @@ -124,11 +124,11 @@ tv_clock = &sched->clock; /* If this is the first CLCK IND */ - if (sched->state == L1SCHED_CLCK_ST_WAIT) { + if (sched->clck_state == L1SCHED_CLCK_ST_WAIT) { l1sched_clck_correct(sched, &tv_now, fn); LOGP(DSCH, LOGL_DEBUG, "Initial clock received: fn=%u\n", fn); - sched->state = L1SCHED_CLCK_ST_OK; + sched->clck_state = L1SCHED_CLCK_ST_OK; return 0; } @@ -195,7 +195,7 @@ void l1sched_clck_reset(struct l1sched_state *sched) { /* Reset internal state */ - sched->state = L1SCHED_CLCK_ST_WAIT; + sched->clck_state = L1SCHED_CLCK_ST_WAIT; /* Stop clock timer */ osmo_timer_del(&sched->clock_timer); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a1b971abaf06c0b1339895cf1748c5eb21d45e6 Gerrit-Change-Number: 28662 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: move FBSB state from struct l1ctl_link to trxcon_inst
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28668 ) Change subject: trxcon: move FBSB state from struct l1ctl_link to trxcon_inst ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I92b50cf1bb36886fbe3d6460af3c0b1c57256ae8 Gerrit-Change-Number: 28668 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:25:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: tests/tdef: assert pointer returned by osmo_tdef_get_entry()
by fixeria 20 Jul '22

20 Jul '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28660 ) Change subject: tests/tdef: assert pointer returned by osmo_tdef_get_entry() ...................................................................... tests/tdef: assert pointer returned by osmo_tdef_get_entry() Coverity complains that we do check if osmo_tdef_get_entry() returns NULL 39 out of 40 times. Check it in test_tdef_set_and_get() too. Change-Id: I96041eab2786d850a49cb38a60a368cef2e476d3 Related: CID#274729 --- M tests/tdef/tdef_test.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c index a2beb6a..c348e69 100644 --- a/tests/tdef/tdef_test.c +++ b/tests/tdef/tdef_test.c @@ -143,6 +143,7 @@ printf("setting 7 = 42\n"); t = osmo_tdef_get_entry(tdefs, 7); + OSMO_ASSERT(t != NULL); OSMO_ASSERT(osmo_tdef_val_in_range(t, 42)); t->val = 42; print_tdef_info(7); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I96041eab2786d850a49cb38a60a368cef2e476d3 Gerrit-Change-Number: 28660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: introduce and use struct 'trxcon_inst'
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28667 ) Change subject: trxcon: introduce and use struct 'trxcon_inst' ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h: https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/1d470a02_a2c3f19f PS3, Line 44: void *priv; where is priv set through API below? I can't see it. https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/44180d4a_c33dbc8a PS3, Line 55: struct trx_instance *trx_if_open(struct trxcon_inst *trxcon, This is a bit strange. All functions here are called trx_if_* but receive a trxcon_inst as object. You may want to clean up this. File src/host/trxcon/src/trxcon.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/64fb9ca2_4bd225b2 PS3, Line 351: trxcon->l1l->priv = trxcon; if some parts are to be turned up into a library you probably want to add setters and getters for these fields. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I23319951c56577085e1092669b5534f9d6bda48d Gerrit-Change-Number: 28667 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: fix coding style in statements applying inverted mask
by pespin 20 Jul '22

20 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28672 ) Change subject: trxcon: fix coding style in statements applying inverted mask ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I28b9fc34e0d40b02d0ca56e9e0bf4463cf4ff336 Gerrit-Change-Number: 28672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 12:15:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log