- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: gsm0808_enc_aoip_trasp_addr: add length check
by fixeria 05 Aug '22

05 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28938 ) Change subject: gsm0808_enc_aoip_trasp_addr: add length check ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I632986b99d841abff0f14c6da65f030175f5c4a1 Gerrit-Change-Number: 28938 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 11:54:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: bssap_conn: fix missing length check
by osmith 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 ) Change subject: bssap_conn: fix missing length check ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/0f4f4161_fd9bcc59 PS3, Line 56: enc_err = gsm0808_enc_aoip_trasp_addr(msg_new, ss) == 0; > Better add paraenthesis it's clearer: enc_err = (gsm0808_enc_aoip_trasp_addr(msg_new, ss) == 0); Ack https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/62a2abef_933eddee PS3, Line 61: enc_err = tlv_encode_one(msg_new, def->def[tag].type, tag, len_v, val) < 0; > Same, paranthesis, otherwise it's easy tonot see the comparision at the end (it happened to me). Ack https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/9ee0768e_1b093a1a PS3, Line 64: if (enc_err) { > BTW, this looks to me a like a good candidate for goto. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db Gerrit-Change-Number: 28582 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 11:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: bssap_conn: fix missing length check
by osmith 05 Aug '22

05 Aug '22

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 to look at the new patch set (#4). Change subject: bssap_conn: fix missing length check ...................................................................... bssap_conn: fix missing length check Check length of msg_new before trying to encode a copy of the IE into it. The code path for IE_AOIP_TRASP_ADDR is different since it gets replaced. With the libosmocore patch in Depends below the gsm0808_enc_aoip_trasp_addr function checks the length. Depends: libosmocore I632986b99d841abff0f14c6da65f030175f5c4a1 Fixes: Coverity CID#273004 Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db --- M src/osmo-bsc-nat/bssap_conn.c 1 file changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/82/28582/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db Gerrit-Change-Number: 28582 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28918 ) Change subject: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS ...................................................................... {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Inspired by GitHub PR#6 [1] by Michael Dickens. Tweaked by me. Change-Id: I7ddd6c75935b0f25d78a948f1577656d77a204e3 Related: [1] https://github.com/osmocom/libosmocore/pull/6 --- M src/gb/Makefile.am M src/sim/Makefile.am M src/usb/Makefile.am 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/Makefile.am b/src/gb/Makefile.am index 022578f..b0fcaa9 100644 --- a/src/gb/Makefile.am +++ b/src/gb/Makefile.am @@ -15,7 +15,11 @@ if ENABLE_GB lib_LTLIBRARIES = libosmogb.la -libosmogb_la_LDFLAGS = $(LTLDFLAGS_OSMOGB) -version-info $(LIBVERSION) +libosmogb_la_LDFLAGS = \ + $(LTLDFLAGS_OSMOGB) \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) libosmogb_la_LIBADD = $(TALLOC_LIBS) \ $(top_builddir)/src/libosmocore.la \ $(top_builddir)/src/vty/libosmovty.la \ diff --git a/src/sim/Makefile.am b/src/sim/Makefile.am index a73ce4b..3d30506 100644 --- a/src/sim/Makefile.am +++ b/src/sim/Makefile.am @@ -15,7 +15,10 @@ libosmosim_la_SOURCES = core.c reader.c class_tables.c \ card_fs_sim.c card_fs_usim.c card_fs_uicc.c \ card_fs_isim.c card_fs_hpsim.c card_fs_tetra.c -libosmosim_la_LDFLAGS = -version-info $(LIBVERSION) +libosmosim_la_LDFLAGS = \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) libosmosim_la_LIBADD = \ $(top_builddir)/src/libosmocore.la \ $(top_builddir)/src/gsm/libosmogsm.la \ diff --git a/src/usb/Makefile.am b/src/usb/Makefile.am index 50d45c2..a1426f9 100644 --- a/src/usb/Makefile.am +++ b/src/usb/Makefile.am @@ -12,7 +12,10 @@ lib_LTLIBRARIES = libosmousb.la libosmousb_la_SOURCES = osmo_libusb.c -libosmousb_la_LDFLAGS = -version-info $(LIBVERSION) +libosmousb_la_LDFLAGS = \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) libosmousb_la_LIBADD = \ $(top_builddir)/src/libosmocore.la \ $(TALLOC_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7ddd6c75935b0f25d78a948f1577656d77a204e3 Gerrit-Change-Number: 28918 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmocore[master]: tests: Run smscb/gsm0341_test during make check
by pespin 05 Aug '22

05 Aug '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28939 ) Change subject: tests: Run smscb/gsm0341_test during make check ...................................................................... tests: Run smscb/gsm0341_test during make check Some initial testing for that module was writen to apparently do some manual tests (rand()) but were never added to testsuite.at. Let's make sure they run during make check (make the test deterministic by removing rand()). Change-Id: Icd4feced06afb749de994195c6b338df006749ad --- M tests/Makefile.am M tests/smscb/gsm0341_test.c A tests/smscb/gsm0341_test.ok M tests/testsuite.at 4 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/28939/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 7d62615..1e8d9d8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -169,6 +169,9 @@ smscb_gsm0341_test_SOURCES = smscb/gsm0341_test.c smscb_gsm0341_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la +smscb_cbsp_test_SOURCES = smscb/cbsp_test.c +smscb_cbsp_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la + sms_sms_test_SOURCES = sms/sms_test.c sms_sms_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la diff --git a/tests/smscb/gsm0341_test.c b/tests/smscb/gsm0341_test.c index d11336f..966a00f 100644 --- a/tests/smscb/gsm0341_test.c +++ b/tests/smscb/gsm0341_test.c @@ -25,7 +25,7 @@ #include <osmocom/core/utils.h> #include <osmocom/core/msgb.h> -struct gsm341_ms_message *gen_msg_from_text(uint16_t msg_id, const char *text) +struct gsm341_ms_message *gen_msg_from_text(uint16_t msg_id, uint8_t msg_code, const char *text) { struct gsm341_ms_message *cbmsg; int text_len = strlen(text); @@ -34,11 +34,11 @@ uint8_t payload[text_len]; int payload_octets; - srand(time(NULL)); + //srand(time(NULL)); gsm_7bit_encode_n(payload, sizeof(payload), text, &payload_octets); //cbmsg = gsm0341_build_msg(NULL, 0, rand(), 0, msg_id, 0x0f, 1, 1, payload, payload_octets); - cbmsg = gsm0341_build_msg(NULL, 0, rand(), 0, msg_id, 0x00, 1, 1, payload, payload_octets); + cbmsg = gsm0341_build_msg(NULL, 0, msg_code, 0, msg_id, 0x00, 1, 1, payload, payload_octets); printf("%s\n", osmo_hexdump_nospc((uint8_t *)cbmsg, sizeof(*cbmsg)+payload_octets)); @@ -50,6 +50,7 @@ uint16_t msg_id = GSM341_MSGID_ETWS_CMAS_MONTHLY_TEST; char *text = "Mahlzeit!"; char tbuf[GSM341_MAX_CHARS+1]; + struct gsm341_ms_message *cbmsg; if (argc > 1) msg_id = atoi(argv[1]); @@ -63,7 +64,8 @@ sizeof(tbuf)-strlen(text)); tbuf[GSM341_MAX_CHARS] = 0; - gen_msg_from_text(msg_id, tbuf); + cbmsg = gen_msg_from_text(msg_id, 1, tbuf); + talloc_free(cbmsg); return EXIT_SUCCESS; } diff --git a/tests/smscb/gsm0341_test.ok b/tests/smscb/gsm0341_test.ok new file mode 100644 index 0000000..600797c --- /dev/null +++ b/tests/smscb/gsm0341_test.ok @@ -0,0 +1 @@ +0010111c0011cd309aad2fa7e9a146a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d168341a8d46a3d100 diff --git a/tests/testsuite.at b/tests/testsuite.at index 44ae539..cc0b8c3 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -102,6 +102,12 @@ AT_CHECK([$abs_top_builddir/tests/smscb/smscb_test], [0], [expout]) AT_CLEANUP +AT_SETUP([smscb_gsm0341]) +AT_KEYWORDS([smscb_gsm0341]) +cat $abs_srcdir/smscb/gsm0341_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/smscb/gsm0341_test], [0], [expout]) +AT_CLEANUP + AT_SETUP([ussd]) AT_KEYWORDS([ussd]) cat $abs_srcdir/ussd/ussd_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad Gerrit-Change-Number: 28939 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: cbsp: Return error if decoding any of the cell id lists fail
by pespin 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28935 to look at the new patch set (#2). Change subject: cbsp: Return error if decoding any of the cell id lists fail ...................................................................... cbsp: Return error if decoding any of the cell id lists fail Change-Id: I5934167f927df0547cb57687e2717489fd1f3719 --- M src/gsm/cbsp.c 1 file changed, 152 insertions(+), 67 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/28935/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5934167f927df0547cb57687e2717489fd1f3719 Gerrit-Change-Number: 28935 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-abis[master]: libosmo{abis,trau}: add -no-undefined to *_la_LDFLAGS
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28921 ) Change subject: libosmo{abis,trau}: add -no-undefined to *_la_LDFLAGS ...................................................................... libosmo{abis,trau}: add -no-undefined to *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: Ib03f939d532173d9e4fcfdf5476c458a21c2c665 --- M src/Makefile.am 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index 1404982..cf8de47 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,7 +11,10 @@ lib_LTLIBRARIES = libosmoabis.la libosmotrau.la -libosmoabis_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(ABIS_LIBVERSION) +libosmoabis_la_LDFLAGS = $(AM_LDFLAGS) \ + -version-info $(ABIS_LIBVERSION) \ + -no-undefined \ + $(NULL) libosmoabis_la_LIBADD = $(COMMONLIBS) libosmoabis_la_SOURCES = init.c \ e1_input.c \ @@ -33,7 +36,10 @@ endif libosmotrau_la_CFLAGS = $(AM_CFLAGS) $(ORTP_CFLAGS) -libosmotrau_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(TRAU_LIBVERSION) +libosmotrau_la_LDFLAGS = $(AM_LDFLAGS) \ + -version-info $(TRAU_LIBVERSION) \ + -no-undefined \ + $(NULL) libosmotrau_la_LIBADD = $(COMMONLIBS) $(ORTP_LIBS) libosmotrau_la_SOURCES = trau/osmo_ortp.c \ trau/trau_frame.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib03f939d532173d9e4fcfdf5476c458a21c2c665 Gerrit-Change-Number: 28921 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-cbc[master]: libosmo-sbcap: add -no-undefined to libosmo_sbcap_la_LDFLAGS
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28922 ) Change subject: libosmo-sbcap: add -no-undefined to libosmo_sbcap_la_LDFLAGS ...................................................................... libosmo-sbcap: add -no-undefined to libosmo_sbcap_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: Id08bbd5ba35ef3f507f60f31a0634f921ec1db65 --- M src/sbcap/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sbcap/Makefile.am b/src/sbcap/Makefile.am index b98bf42..4130a90 100644 --- a/src/sbcap/Makefile.am +++ b/src/sbcap/Makefile.am @@ -376,7 +376,7 @@ sbcap_LIBVERSION=0:0:0 lib_LTLIBRARIES = libosmo-sbcap.la -libosmo_sbcap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(sbcap_LIBVERSION) +libosmo_sbcap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(sbcap_LIBVERSION) -no-undefined libosmo_sbcap_la_LIBADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) \ $(ASN1C_LIBS) libosmo-asn1-sbcap.la libosmo_sbcap_la_SOURCES = sbcap_common.c -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id08bbd5ba35ef3f507f60f31a0634f921ec1db65 Gerrit-Change-Number: 28922 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-iuh[master]: libosmo-{hnbap,ranap,rua,sabp}: add -no-undefined to *_la_LDFLAGS
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28924 ) Change subject: libosmo-{hnbap,ranap,rua,sabp}: add -no-undefined to *_la_LDFLAGS ...................................................................... libosmo-{hnbap,ranap,rua,sabp}: add -no-undefined to *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: I659d277049173e8fc86934140d552f6a494971a1 --- M src/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index 87f6837..9e447e6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -66,23 +66,23 @@ RUA_LIBVERSION=0:0:0 SABP_LIBVERSION=1:0:0 lib_LTLIBRARIES = libosmo-hnbap.la libosmo-ranap.la libosmo-rua.la libosmo-sabp.la -libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) +libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) -no-undefined libosmo_hnbap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) hnbap/libosmo-asn1-hnbap.la libosmo_hnbap_la_SOURCES = hnbap_common.c hnbap_encoder.c hnbap_decoder.c -libosmo_ranap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RANAP_LIBVERSION) +libosmo_ranap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RANAP_LIBVERSION) -no-undefined libosmo_ranap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) ranap/libosmo-asn1-ranap.la libosmo_ranap_la_SOURCES = ranap_common.c ranap_encoder.c ranap_decoder.c ranap_msg_factory.c iu_helpers.c \ ranap_common_cn.c ranap_common_ran.c iu_client.c iu_client_vty.c -libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RUA_LIBVERSION) +libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RUA_LIBVERSION) -no-undefined libosmo_rua_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) rua/libosmo-asn1-rua.la libosmo_rua_la_SOURCES = rua_common.c rua_encoder.c rua_decoder.c rua_msg_factory.c -libosmo_sabp_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(SABP_LIBVERSION) +libosmo_sabp_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(SABP_LIBVERSION) -no-undefined libosmo_sabp_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) sabp/libosmo-asn1-sabp.la libosmo_sabp_la_SOURCES = sabp_common.c sabp_encoder.c sabp_decoder.c -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I659d277049173e8fc86934140d552f6a494971a1 Gerrit-Change-Number: 28924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-iuh[master]: libosmo-rua: fix copy-pasted -version-info: {HNBAP->RUA}_LIBVERSION
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28923 ) Change subject: libosmo-rua: fix copy-pasted -version-info: {HNBAP->RUA}_LIBVERSION ...................................................................... libosmo-rua: fix copy-pasted -version-info: {HNBAP->RUA}_LIBVERSION Change-Id: I71b859d3c9ecfaf9bffa6341291267ddef071448 --- M src/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved daniel: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index c2f9adf..87f6837 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -77,7 +77,7 @@ libosmo_ranap_la_SOURCES = ranap_common.c ranap_encoder.c ranap_decoder.c ranap_msg_factory.c iu_helpers.c \ ranap_common_cn.c ranap_common_ran.c iu_client.c iu_client_vty.c -libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) +libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RUA_LIBVERSION) libosmo_rua_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) rua/libosmo-asn1-rua.la libosmo_rua_la_SOURCES = rua_common.c rua_encoder.c rua_decoder.c rua_msg_factory.c -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I71b859d3c9ecfaf9bffa6341291267ddef071448 Gerrit-Change-Number: 28923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log