- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: cbsp: Fix decoding of Fail List
by fixeria 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28941 ) Change subject: cbsp: Fix decoding of Fail List ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16ed9bd65109a7ce32ff43c5789b4544479838e7 Gerrit-Change-Number: 28941 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 13:27:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cbsp: Guard against malformed msgb without l1h,l2h being passed
by fixeria 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28940 ) Change subject: cbsp: Guard against malformed msgb without l1h,l2h being passed ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8854c780cfd96e67df10c1fc38c6b99ec07422f Gerrit-Change-Number: 28940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 13:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: tests: Run smscb/gsm0341_test during make check
by fixeria 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28939 ) Change subject: tests: Run smscb/gsm0341_test during make check ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad Gerrit-Change-Number: 28939 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 13:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cbsp: Return error if decoding any of the cell id lists fail
by fixeria 05 Aug '22

05 Aug '22

Attention is currently required from: pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28935 ) Change subject: cbsp: Return error if decoding any of the cell id lists fail ...................................................................... Patch Set 2: Code-Review+2 (3 comments) File src/gsm/cbsp.c: https://gerrit.osmocom.org/c/libosmocore/+/28935/comment/48dc53f0_b49edc57 PS1, Line 661: TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); > cosmetic: alignment (here and below) Done https://gerrit.osmocom.org/c/libosmocore/+/28935/comment/207ab9aa_634580f1 PS1, Line 959: cbsp_decode_loading_list(&out->loading_list, ctx, > Check for failure here as well? Done https://gerrit.osmocom.org/c/libosmocore/+/28935/comment/8e81ec55_46055334 PS1, Line 990: cbsp_decode_loading_list(&out->loading_list, ctx, > And here Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5934167f927df0547cb57687e2717489fd1f3719 Gerrit-Change-Number: 28935 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 13:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cbsp: Fix decoding of Fail List
by pespin 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28941 to look at the new patch set (#2). Change subject: cbsp: Fix decoding of Fail List ...................................................................... cbsp: Fix decoding of Fail List The decoding pointer was not increased correctly, ending up in reading by 1 byte offset for each item in the list. Change-Id: I16ed9bd65109a7ce32ff43c5789b4544479838e7 --- M src/gsm/cbsp.c M tests/Makefile.am A tests/smscb/cbsp_test.c A tests/smscb/cbsp_test.ok M tests/testsuite.at 5 files changed, 125 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/28941/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16ed9bd65109a7ce32ff43c5789b4544479838e7 Gerrit-Change-Number: 28941 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: gsm0808_enc_aoip_trasp_addr: add length check
by fixeria 05 Aug '22

05 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28938 ) Change subject: gsm0808_enc_aoip_trasp_addr: add length check ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I632986b99d841abff0f14c6da65f030175f5c4a1 Gerrit-Change-Number: 28938 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 13:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cbsp: Fix decoding of Fail List
by pespin 05 Aug '22

05 Aug '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28941 ) Change subject: cbsp: Fix decoding of Fail List ...................................................................... cbsp: Fix decoding of Fail List The decoding pointer was not increased correctly, ending up in reading by 1 byte offset for each item in the list. Change-Id: I16ed9bd65109a7ce32ff43c5789b4544479838e7 --- M src/gsm/cbsp.c M tests/Makefile.am A tests/smscb/cbsp_test.c A tests/smscb/cbsp_test.ok M tests/testsuite.at 5 files changed, 125 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/28941/1 diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index 81ba81e..7411056 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -537,8 +537,8 @@ struct osmo_cbsp_fail_ent *ent = talloc_zero(ctx, struct osmo_cbsp_fail_ent); unsigned int len_remain = len - (cur - buf); OSMO_ASSERT(ent); - ent->id_discr = cur[0]; - rc = gsm0808_decode_cell_id_u(&ent->cell_id, ent->id_discr, cur+1, len_remain-1); + ent->id_discr = *cur++; + rc = gsm0808_decode_cell_id_u(&ent->cell_id, ent->id_discr, cur, len_remain-1); if (rc < 0) { osmo_cbsp_errstr = "fail list: error decoding cell_id_union"; return rc; diff --git a/tests/Makefile.am b/tests/Makefile.am index b5448c0..8c7e40a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -48,6 +48,7 @@ iuup/iuup_test \ smscb/smscb_test \ smscb/gsm0341_test \ + smscb/cbsp_test \ $(NULL) if ENABLE_MSGFILE @@ -171,6 +172,9 @@ smscb_gsm0341_test_SOURCES = smscb/gsm0341_test.c smscb_gsm0341_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la +smscb_cbsp_test_SOURCES = smscb/cbsp_test.c +smscb_cbsp_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la + sms_sms_test_SOURCES = sms/sms_test.c sms_sms_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la @@ -430,6 +434,7 @@ iuup/iuup_test.ok \ smscb/smscb_test.ok \ smscb/gsm0341_test.ok \ + smscb/cbsp_test.ok \ $(NULL) if ENABLE_LIBSCTP @@ -486,6 +491,8 @@ >$(srcdir)/smscb/smscb_test.ok smscb/gsm0341_test \ >$(srcdir)/smscb/gsm0341_test.ok + smscb/cbsp_test \ + >$(srcdir)/smscb/cbsp_test.ok ussd/ussd_test \ >$(srcdir)/ussd/ussd_test.ok auth/milenage_test \ diff --git a/tests/smscb/cbsp_test.c b/tests/smscb/cbsp_test.c new file mode 100644 index 0000000..06c6433 --- /dev/null +++ b/tests/smscb/cbsp_test.c @@ -0,0 +1,108 @@ +/* + * (C) 2022 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +#include <string.h> +#include <stdio.h> +#include <stdlib.h> + +#include <osmocom/core/utils.h> +#include <osmocom/core/msgb.h> + +#include <osmocom/gsm/protocol/gsm_48_049.h> +#include <osmocom/gsm/cbsp.h> + +/* +CBSP WRITE-REPLACE FAILURE + Message Type: WRITE-REPLACE FAILURE (3) + Message Length: 44 + IE: Message Identifier: 0x0031 + Information Element Identifier: Message Identifier (14) + Message Identifier: 0x0031 + IE: New Serial Number: 0x4170 + Information Element Identifier: New Serial Number (3) + New Serial Number: 0x4170 + IE: Failure List: 2 items + Information Element Identifier: Failure List (9) + Information Element Length: 15 + Failure List Item: MCC 901 International Mobile, shared code, MNC 70 Clementvale Baltic OÜ, LAC 0x0018, CI 0x0030: Cause Cell-identity-not-valid + Cell ID Discriminator: CGI (0) + Mobile Country Code (MCC): International Mobile, shared code (901) + Mobile Network Code (MNC): Clementvale Baltic OÜ (70) + Location Area Code (LAC): 0x0018 + Cell Identifier (CI): 0x0030 + Cause: Cell-identity-not-valid (0x03) + Failure List Item: LAC 02711, CI 0xc351: Cause LAI-or-LAC-not-valid + Cell ID Discriminator: LAC+CI (1) + Location Area Code (LAC): 0x2711 + Cell Identifier (CI): 0xc351 + Cause: LAI-or-LAC-not-valid (0x0f) + IE: Cell List (CGI): 2 items + Information Element Identifier: Cell List (4) + Information Element Length: 15 + Cell ID Discriminator: CGI (0) + Cell List Item: MCC 901 International Mobile, shared code, MNC 70 Clementvale Baltic OÜ, LAC 0x0017, CI 0x002a + Mobile Country Code (MCC): International Mobile, shared code (901) + Mobile Network Code (MNC): Clementvale Baltic OÜ (70) + Location Area Code (LAC): 0x0017 + Cell Identifier (CI): 0x002a + Cell List Item: MCC 901 International Mobile, shared code, MNC 70 Clementvale Baltic OÜ, LAC 0x0018, CI 0x002a + Mobile Country Code (MCC): International Mobile, shared code (901) + Mobile Network Code (MNC): Clementvale Baltic OÜ (70) + Location Area Code (LAC): 0x0018 + Cell Identifier (CI): 0x002a + IE: Channel Indicator: basic channel + Information Element Identifier: Channel Indicator (18) + Channel Indicator: basic channel (0x00) +*/ +const static char write_repl_fail_with_failure_list[] = + "0300002c0e003103417009000f0009f1070018003003012711c3510f04000f0009f1070017002a09f1070018002a1200"; + +static struct msgb *msgb_from_hex(unsigned int size, const char *hex) +{ + struct msgb *msg = msgb_alloc(size, "test_cbsp"); + OSMO_ASSERT(msg); + msg->l1h = msgb_put(msg, osmo_hexparse(hex, msg->data, msgb_tailroom(msg))); + msg->l2h = msg->l1h + sizeof(struct cbsp_header); + return msg; +} + +static void test_decode() +{ + struct msgb *msg; + struct osmo_cbsp_decoded *cbsp_dec; + + printf("=== %s start ===\n", __func__); + + msg = msgb_from_hex(sizeof(write_repl_fail_with_failure_list), + write_repl_fail_with_failure_list); + + cbsp_dec = osmo_cbsp_decode(NULL, msg); + OSMO_ASSERT(cbsp_dec); + + talloc_free(cbsp_dec); + msgb_free(msg); + + printf("=== %s end ===\n", __func__); +} + +int main(int argc, char **argv) +{ + test_decode(); + + return EXIT_SUCCESS; +} diff --git a/tests/smscb/cbsp_test.ok b/tests/smscb/cbsp_test.ok new file mode 100644 index 0000000..a837de5 --- /dev/null +++ b/tests/smscb/cbsp_test.ok @@ -0,0 +1,2 @@ +=== test_decode start === +=== test_decode end === diff --git a/tests/testsuite.at b/tests/testsuite.at index cc0b8c3..6b2e75f 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -108,6 +108,12 @@ AT_CHECK([$abs_top_builddir/tests/smscb/gsm0341_test], [0], [expout]) AT_CLEANUP +AT_SETUP([smscb_cbsp]) +AT_KEYWORDS([smscb_cbsp]) +cat $abs_srcdir/smscb/cbsp_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/smscb/cbsp_test], [0], [expout]) +AT_CLEANUP + AT_SETUP([ussd]) AT_KEYWORDS([ussd]) cat $abs_srcdir/ussd/ussd_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16ed9bd65109a7ce32ff43c5789b4544479838e7 Gerrit-Change-Number: 28941 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: send SACCH blocks in TC_rsl_ms_pwr_dyn_{up,max,ass_updown}
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28869 ) Change subject: BTS_Tests: send SACCH blocks in TC_rsl_ms_pwr_dyn_{up,max,ass_updown} ...................................................................... BTS_Tests: send SACCH blocks in TC_rsl_ms_pwr_dyn_{up,max,ass_updown} We used to rely on trxcon sendig dummy RR Measurement Reports and patching the L1 SACCH Header with the configured MS Power Level and Timing Advance values. Since recently, the following testcases started to fail because trxcon does not patch dummy MRs anymore: * TC_rsl_ms_pwr_dyn_ass_updown, * TC_rsl_ms_pwr_dyn_max, and * TC_rsl_ms_pwr_dyn_up. Do not rely on dummy MRs, send SACCH blocks with the expected MS Power Level and Timing Advance values from the testsuites. f_send_meas_rep() internally uses: * g_pars.l1_pars.ms_power_level, and * g_pars.l1_pars.ms_actual_ta. Change-Id: I31dd6b9026d04403092256176f67785a0a6486ad Related: OS#5635 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 5cf1900..395059a 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2979,6 +2979,8 @@ T2.start; alt { [] as_l1_sacch_l1h(l1h) { + f_send_meas_rep(ts_MeasurementResults); + if (l1h.ms_power_lvl < (pwr_var + 6)) { repeat; } @@ -2998,6 +3000,8 @@ T4.start; alt { [] as_l1_sacch_l1h(l1h) { + f_send_meas_rep(ts_MeasurementResults); + if (l1h.ms_power_lvl > pwr_var) { repeat; } @@ -3040,7 +3044,10 @@ timer T1 := 10.0; T1.start; alt { - [] as_l1_sacch_l1h(l1h) { repeat; } + [] as_l1_sacch_l1h(l1h) { + f_send_meas_rep(ts_MeasurementResults); + repeat; + } [] L1CTL.receive { repeat; } [] T1.timeout { if (not isbound(l1h)) { @@ -3086,7 +3093,10 @@ timer T1 := 9.0 * 1.92 + 1.92; T1.start; alt { - [] as_l1_sacch_l1h(l1h) { repeat; } + [] as_l1_sacch_l1h(l1h) { + f_send_meas_rep(ts_MeasurementResults); + repeat; + } [] L1CTL.receive { repeat; } [] T1.timeout { if (not isbound(l1h)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I31dd6b9026d04403092256176f67785a0a6486ad Gerrit-Change-Number: 28869 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: separate f_send_meas_rep() from f_transceive_meas_rep()
by fixeria 05 Aug '22

05 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28880 ) Change subject: BTS_Tests: separate f_send_meas_rep() from f_transceive_meas_rep() ...................................................................... BTS_Tests: separate f_send_meas_rep() from f_transceive_meas_rep() The key difference is that f_send_meas_rep() simply sends an RR Measurement Report and does not wait until it's received on the RSL. Change-Id: Ia5d0315e053702df5fa8dad8c6c66c11c9f3edcb --- M bts/BTS_Tests.ttcn 1 file changed, 22 insertions(+), 6 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 223e55b..5cf1900 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -778,12 +778,31 @@ var RSL_Message rx := f_rsl_transceive_ret(tx, exp_rx, id, ignore_other); } +/* Send the given measurement results to the IUT over the Um interface */ +friend function f_send_meas_rep(template (value) MeasurementResults meas_res) +runs on ConnHdlr { + var template (value) SacchL1Header l1h; + var octetstring l2; + + /* RR Measurement Report to be sent */ + var GsmRrL3Message meas_rep := { + header := valueof(t_RrL3Header(MEASUREMENT_REPORT)), + payload := { meas_rep := { meas_res := valueof(meas_res) } } + }; + + /* TITAN has weird (and often unusable) padding model, so we pad here manaully */ + l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 21, '00'O); + l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, g_pars.l1_pars.ms_actual_ta); + + /* Send RR Measurement Report over the Um interface */ + L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); +} + /* Send the given measurement results to the IUT over the Um interface, * wait for the IUT to receive then and forward over the A-bis/RSL interface. */ friend function f_transceive_meas_rep(template (value) MeasurementResults meas_res) runs on ConnHdlr { - var template (value) SacchL1Header l1h; - var octetstring l2, l3; + var octetstring l3; timer T; /* RR Measurement Report to be sent */ @@ -794,11 +813,8 @@ /* TITAN has weird (and often unusable) padding model, so we pad here manaully */ l3 := f_pad_oct(enc_GsmRrL3Message(meas_rep), 18, '00'O); - l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 21, '00'O); - l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, g_pars.l1_pars.ms_actual_ta); - /* Send RR Measurement Report over the Um interface */ - L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); + f_send_meas_rep(meas_res); /* Expect MEASurement RESult on the A-bis/RSL interface */ T.start(2.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5d0315e053702df5fa8dad8c6c66c11c9f3edcb Gerrit-Change-Number: 28880 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmocore[master]: tests: Run smscb/gsm0341_test during make check
by pespin 05 Aug '22

05 Aug '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28939 to look at the new patch set (#3). Change subject: tests: Run smscb/gsm0341_test during make check ...................................................................... tests: Run smscb/gsm0341_test during make check Some initial testing for that module was writen to apparently do some manual tests (rand()) but were never added to testsuite.at. Let's make sure they run during make check (make the test deterministic by removing rand()). Change-Id: Icd4feced06afb749de994195c6b338df006749ad --- M tests/Makefile.am M tests/smscb/gsm0341_test.c A tests/smscb/gsm0341_test.ok M tests/testsuite.at 4 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/28939/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad Gerrit-Change-Number: 28939 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log