- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes
by msuraev 10 Aug '22

10 Aug '22

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28996 ) Change subject: Diversify osmo_sockaddr_str_*() error codes ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > Is there really a need to have a separate error code for all paths? If an invalid value is passed, t […] To me the codes look perfectly fitting while using debugger to work around the inconvenience we've created ourselves makes no sense. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10 Gerrit-Change-Number: 28996 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 15:47:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux.h: Define default Osmux port
by pespin 10 Aug '22

10 Aug '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29029 ) Change subject: osmux.h: Define default Osmux port ...................................................................... osmux.h: Define default Osmux port This has been the port being used historically in most osmux setups, and projects using osmux.h have it defined locally. Let's define it here so that there's no need to define it on each client. Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd --- M include/osmocom/netif/osmux.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/29/29029/1 diff --git a/include/osmocom/netif/osmux.h b/include/osmocom/netif/osmux.h index ed5c1ab..ff537c0 100644 --- a/include/osmocom/netif/osmux.h +++ b/include/osmocom/netif/osmux.h @@ -13,6 +13,8 @@ * Osmocom multiplex protocol helpers */ +#define OSMUX_DEFAULT_PORT 1984 + /* OSmux header: * * rtp_m (1 bit): RTP M field (RFC3550, RFC4867) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd Gerrit-Change-Number: 29029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header
by pespin 10 Aug '22

10 Aug '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29028 ) Change subject: osmux.h: Add missing msgb.h header ...................................................................... osmux.h: Add missing msgb.h header Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f --- M include/osmocom/netif/osmux.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/28/29028/1 diff --git a/include/osmocom/netif/osmux.h b/include/osmocom/netif/osmux.h index 6305dc8..ed5c1ab 100644 --- a/include/osmocom/netif/osmux.h +++ b/include/osmocom/netif/osmux.h @@ -3,6 +3,7 @@ #include <osmocom/core/endian.h> #include <osmocom/core/timer.h> +#include <osmocom/core/msgb.h> /*! \addtogroup osmux * @{ -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f Gerrit-Change-Number: 29028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: rsl: rx ipac crcx/mdcx: Log payload_type2
by fixeria 10 Aug '22

10 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29027 ) Change subject: rsl: rx ipac crcx/mdcx: Log payload_type2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc Gerrit-Change-Number: 29027 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 15:28:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: {jobs,coverity}: add a new project - libosmo-gprs
by fixeria 10 Aug '22

10 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29019 ) Change subject: {jobs,coverity}: add a new project - libosmo-gprs ...................................................................... {jobs,coverity}: add a new project - libosmo-gprs Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436 --- M coverity/build_Osmocom.sh M coverity/prepare_source_Osmocom.sh M jobs/gerrit-lint.yml M jobs/gerrit-verifications.yml M jobs/master-builds.yml M scripts/common.sh 6 files changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 4291558..da2244a 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -74,6 +74,7 @@ build_libasn1c build_libusrp build_default libosmo-abis +build_default libosmo-gprs build_default libosmo-netif build_default libosmo-pfcp build_default libosmo-sccp diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 73baf2c..e97c885 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -12,6 +12,7 @@ libosmo-abis libosmocore libosmo-dsp + libosmo-gprs libosmo-netif libosmo-pfcp libosmo-sccp diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index cc83bea..9a1c1c5 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -18,6 +18,7 @@ - libasn1c - libgtpnl - libosmo-abis + - libosmo-gprs - libosmo-netif - libosmo-pfcp - libosmo-sccp diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index a4af343..85c78b4 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -55,6 +55,7 @@ - libasn1c - libgtpnl - libosmo-abis + - libosmo-gprs - libosmo-netif - libosmo-pfcp - libosmo-sccp diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index f48bae5..b5c42f1 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -83,6 +83,15 @@ trigger: master-osmo-gmr email: gerrit-log(a)lists.osmocom.org laforge(a)gnumonks.org 246tnt(a)gmail.com + - libosmo-gprs: + # Full triggers would be: + # trigger: > + # master-osmo-pcu + # Optimized: + # (see comment at libosmocore) + trigger: > + master-osmo-pcu + - libosmo-netif: # Full triggers would be: # trigger: > @@ -152,6 +161,8 @@ # -> master-osmo-mgw # -> master-osmo-sgsn # -> master-osmo-bts + # -> master-libosmo-gprs + # -> master-osmo-pcu # -> master-libosmo-pfcp # -> master-osmo-upf # -> master-osmo-hnbgw @@ -165,7 +176,6 @@ master-osmo-ggsn, master-osmo-gmr, master-osmo-pcap, - master-osmo-pcu, master-osmo-sip-connector, master-osmo-tetra, master-osmo-trx, diff --git a/scripts/common.sh b/scripts/common.sh index 8e784cc..e085123 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -10,6 +10,7 @@ OSMO_RELEASE_REPOS=" libasn1c libosmo-abis + libosmo-gprs libosmo-netif libosmo-pfcp libosmo-sccp -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436 Gerrit-Change-Number: 29019 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: jobs/master-builds: fix libosmo-pfcp related trigger mess
by fixeria 10 Aug '22

10 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29017 ) Change subject: jobs/master-builds: fix libosmo-pfcp related trigger mess ...................................................................... jobs/master-builds: fix libosmo-pfcp related trigger mess * master-libosmo-pfcp is triggered directly by libosmocore, not by master-libosmo-netif, nor master-libosmo-abis, so ** fix comment explaining the hierarchy. * master-osmo-upf is triggered by master-libosmo-pfcp, so ** it should not be triggered directly by libosmocore. Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42 Fixes: Icb75adec886cf1053b80c968fea59e597ed289a7 --- M jobs/master-builds.yml 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index acb8216..f48bae5 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -151,19 +151,18 @@ # -> master-osmo-hlr # -> master-osmo-mgw # -> master-osmo-sgsn - # -> master-libosmo-pfcp - # -> master-osmo-upf - # -> master-osmo-hnbgw # -> master-osmo-bts + # -> master-libosmo-pfcp + # -> master-osmo-upf + # -> master-osmo-hnbgw # -> master-osmo-ggsn # -> master-osmo-sgsn - # -> master-osmo-upf # [...] trigger: > master-libosmo-abis, + master-libosmo-pfcp, master-osmo-gbproxy, master-osmo-ggsn, - master-osmo-upf, master-osmo-gmr, master-osmo-pcap, master-osmo-pcu, @@ -171,7 +170,6 @@ master-osmo-tetra, master-osmo-trx, master-osmocom-bb, - master-libosmo-pfcp, SIMtrace, xgoldmon -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42 Gerrit-Change-Number: 29017 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf
by fixeria 10 Aug '22

10 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29018 ) Change subject: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf ...................................................................... OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5 --- M scripts/common.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/common.sh b/scripts/common.sh index e8603a3..8e784cc 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -11,6 +11,7 @@ libasn1c libosmo-abis libosmo-netif + libosmo-pfcp libosmo-sccp libosmocore libsmpp34 @@ -37,6 +38,7 @@ osmo-sysmon osmo-trx osmo-uecups + osmo-upf osmocom-bb simtrace2 " -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5 Gerrit-Change-Number: 29018 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: {jobs,coverity}: add a new project - libosmo-gprs
by fixeria 10 Aug '22

10 Aug '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29019 ) Change subject: {jobs,coverity}: add a new project - libosmo-gprs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436 Gerrit-Change-Number: 29019 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 10 Aug 2022 15:27:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf
by fixeria 10 Aug '22

10 Aug '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29018 ) Change subject: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5 Gerrit-Change-Number: 29018 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 15:27:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Rename s/use_osmux/use_osmux_cn/
by daniel 10 Aug '22

10 Aug '22

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29008 ) Change subject: bsc: Rename s/use_osmux/use_osmux_cn/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bde4e6772c18043dd763d7747b5dbe40e0da3b8 Gerrit-Change-Number: 29008 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 15:03:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log