pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009 )
Change subject: bsc: Set g_osmux_enabled_cn directly in the test
......................................................................
bsc: Set g_osmux_enabled_cn directly in the test
We want to add more options later on, and we don't want to be passing
all of them as params. Let's simply set the global fields directly in
the test and let f_init() use the confgured values.
Change-Id: I27b685c2c22cf876b5eba79cf8ad151a2643ecb1
---
M bsc/BSC_Tests.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
daniel: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index d8a660c..7f4ce46 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1083,7 +1083,6 @@
}
f_vty_transceive(BSCVTY, "exit");
f_vty_transceive(BSCVTY, "exit");
- g_osmux_enabled_cn := allow;
}
function f_init_vty(charstring id := "foo") runs on test_CT {
@@ -1187,7 +1186,7 @@
* \param handler_mode Start an RSL_Emulation_CT component (true) or not (false).
* \param nr_msc Number of virtual MSCs to bring up to connect to osmo-bsc.
*/
-function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false, boolean allow_osmux_cn := false,
+function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false,
integer nr_msc := 1, float guard_timeout := 30.0) runs on test_CT {
var integer bssap_idx;
@@ -1200,7 +1199,7 @@
activate(as_Tguard());
f_init_vty("VirtMSC");
- f_vty_allow_osmux_cn(allow_osmux_cn);
+ f_vty_allow_osmux_cn(g_osmux_enabled_cn);
var my_BooleanList allow_attach := { false, false, false };
f_init_statsd("VirtMSC", vc_STATSD, mp_test_ip, mp_bsc_statsd_port);
@@ -5262,7 +5261,8 @@
pars.expect_mr_conf_ie := mr_conf;
pars.use_osmux_cn := true;
- f_init(1, true, true);
+ g_osmux_enabled_cn := true;
+ f_init(1, true);
f_sleep(1.0);
f_vty_amr_start_mode_set(false, "1");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I27b685c2c22cf876b5eba79cf8ad151a2643ecb1
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/29031
to look at the new patch set (#3).
Change subject: Clean up osmo-bts-*/Makefile.am
......................................................................
Clean up osmo-bts-*/Makefile.am
Make them more easy to read and edit by splitting to one lement per
line when several elements are present.
Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-virtual/Makefile.am
6 files changed, 305 insertions(+), 51 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/29031
to look at the new patch set (#2).
Change subject: Clean up osmo-bts-*/Makefile.am
......................................................................
Clean up osmo-bts-*/Makefile.am
Make them more easy to read and edit by splitting to one lement per
line when several elements are present.
Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-virtual/Makefile.am
6 files changed, 303 insertions(+), 51 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels, laforge, fixeria.
Hello Jenkins Builder, laforge, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28986
to look at the new patch set (#3).
Change subject: GTP mockup: list active GTP endecaps actions
......................................................................
GTP mockup: list active GTP endecaps actions
In GTP mockup mode, keep a GTP device (struct upf_gtp_dev) so that
the GTP actions activated in mockup mode are listed on VTY.
Drop the global GTP mockup mode, and instead allow single GTP devices to
be mockup devices.
Do not always open the mnl_socket, but only open it when an actual
non-mockup GTP device is being opened. (In the presence of non-mockup
GTP devices, this still happens directly upon program startup.)
The GTP mockup was first introduced for VTY tests during 'make check'.
So far, in mockup mode, all GTP tunnel actions were simply cut short,
and no tunnels were ever listed as active.
TTCN3 tests do query osmo-upf to list currently active tunnels, so the
GTP mockup fails these tests. To allow running TTCN3 tests without
cap_net_admin privileges, always list (fake) active GTP tunnels.
Useful in a lab environment: send PFCP commands to osmo-upf and get a
listing of GTP tunnels that would have been active.
So far, osmo-upf always uses only the first GTP device configured, but
if we add support for multiple GTP devices, this patch allows putting
only single devices in mockup mode.
Related: SYS#5599
Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
---
M doc/examples/osmo-upf/osmo-upf-mockup.cfg
M include/osmocom/upf/upf.h
M include/osmocom/upf/upf_gtp.h
M src/osmo-upf/osmo_upf_main.c
M src/osmo-upf/up_gtp_action.c
M src/osmo-upf/upf.c
M src/osmo-upf/upf_gtp.c
M src/osmo-upf/upf_vty.c
M tests/upf.vty
9 files changed, 82 insertions(+), 66 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/86/28986/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset