- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: repo-install-test: don't use next repository
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29156 ) Change subject: repo-install-test: don't use next repository ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I73a6c051c423eb30ddeab1688fc78fe959e60cf4 Gerrit-Change-Number: 29156 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:24:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/ttcn3: use new packages for 20YYqX testsuite
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29155 ) Change subject: jobs/ttcn3: use new packages for 20YYqX testsuite ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I34050da1e2444cf684ff8bd07673e3268b4dd497 Gerrit-Change-Number: 29155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:22:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/master-builds: clone from gerrit.osmocom.org
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: osmith, laforge, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29153 ) Change subject: jobs/master-builds: clone from gerrit.osmocom.org ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f345be55f5c7eb42655dc346776ad8891af126d Gerrit-Change-Number: 29153 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:22:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/ttcn3: drop obs-mirror workaround for centos8
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29154 ) Change subject: jobs/ttcn3: drop obs-mirror workaround for centos8 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic7920ad71a0cb6362883f8b9ed3dbc9bbb992988 Gerrit-Change-Number: 29154 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[2022q2]: osmo-bts-trx: amr_loop: trigger the loop unconditionally
by fixeria 19 Aug '22

19 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29149 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... osmo-bts-trx: amr_loop: trigger the loop unconditionally The logic responsible for enabling and disabling the loop appears to be broken: during my experiments trx_loop_amr_set() was never called with loop=1. It's not clear what's the motivation behind this breaker, so I propose to rip it out for now. This patch finally makes the loop work (confirmed with a TEMS phone). Related: SYS#5917, OS#4984 Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c (cherry picked from commit 541b7525aee81fbeed23be9cddf909ebcca6ed6d) --- M include/osmo-bts/scheduler.h M src/osmo-bts-trx/amr_loop.c M src/osmo-bts-trx/sched_lchan_tchf.c 3 files changed, 1 insertion(+), 30 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h index ec31eab..c96b70b 100644 --- a/include/osmo-bts/scheduler.h +++ b/include/osmo-bts/scheduler.h @@ -119,7 +119,6 @@ uint8_t dl_ft; /* current downlink FT index */ uint8_t ul_cmr; /* current uplink CMR index */ uint8_t dl_cmr; /* current downlink CMR index */ - uint8_t amr_loop; /* if AMR loop is enabled */ uint8_t amr_last_dtx; /* last received dtx frame type */ /* TCH/H */ diff --git a/src/osmo-bts-trx/amr_loop.c b/src/osmo-bts-trx/amr_loop.c index ce89091..859f39b 100644 --- a/src/osmo-bts-trx/amr_loop.c +++ b/src/osmo-bts-trx/amr_loop.c @@ -40,10 +40,6 @@ const uint8_t mi = chan_state->ul_ft; /* mode index 0..3 */ int lqual_cb = meas_set->ci_cb; /* cB (centibel) */ - /* check if loop is enabled */ - if (!chan_state->amr_loop) - return; - /* count per-block C/I samples for further averaging */ if (lchan->type == GSM_LCHAN_TCH_H) { chan_state->lqual_cb_num += 2; @@ -109,16 +105,3 @@ LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG, "Keeping the current AMR codec " "mode[%u]=%u\n", mi, cfg->mode[mi].mode); } - -void trx_loop_amr_set(struct l1sched_chan_state *chan_state, int loop) -{ - if (chan_state->amr_loop == loop) - return; - if (!chan_state->amr_loop) { - /* reset the link quality measurements */ - chan_state->lqual_cb_num = 0; - chan_state->lqual_cb_sum = 0; - } - - chan_state->amr_loop = loop; -} diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 6a90327..b530d25 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -384,7 +384,7 @@ if (msg_tch) { int len; uint8_t cmr_codec; - int cmr, ft, i; + int ft, i; enum osmo_amr_type ft_codec; enum osmo_amr_quality bfi; int8_t sti, cmi; @@ -416,22 +416,11 @@ LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); goto free_bad_msg; } - cmr = -1; ft = -1; for (i = 0; i < chan_state->codecs; i++) { - if (chan_state->codec[i] == cmr_codec) - cmr = i; if (chan_state->codec[i] == ft_codec) ft = i; } - if (cmr >= 0) { /* new request */ - chan_state->dl_cmr = cmr; - /* disable AMR loop */ - trx_loop_amr_set(chan_state, 0); - } else { - /* enable AMR loop */ - trx_loop_amr_set(chan_state, 1); - } if (ft < 0) { LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Codec (FT = %d) of RTP frame not in list\n", ft_codec); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2022q2 Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 29149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[2022q2]: osmo-bts-trx: amr_loop: trigger the loop unconditionally
by fixeria 19 Aug '22

19 Aug '22

Attention is currently required from: laforge, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29149 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2022q2 Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 29149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 13:03:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: debian: add missing deps
by fixeria 19 Aug '22

19 Aug '22

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29142 ) Change subject: debian: add missing deps ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I068736d513ddb54b9a62c1d7970a0fbff3095b4b Gerrit-Change-Number: 29142 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 12:02:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: debian: add missing deps
by osmith 19 Aug '22

19 Aug '22

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29142 ) Change subject: debian: add missing deps ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Patch looks good. I've added libnftnl and libnftables to our OBS in nightly. However we'll need an additional fix for this: [ 149s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_gtlvs_decode' [ 149s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_gtlvs_encode' [ 149s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_t16l16v_cfg' [ 149s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libosmo-pfcp.so: undefined reference to `osmo_gtlvs_encode_to_str_buf' https://obs.osmocom.org/package/live_build_log/home:osmith:nightly/osmo-upf… -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I068736d513ddb54b9a62c1d7970a0fbff3095b4b Gerrit-Change-Number: 29142 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 11:21:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-gsm-manuals[master]: TRXD: further clarify meaning of Training / Synch. Sequence Code
by fixeria 19 Aug '22

19 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29162 ) Change subject: TRXD: further clarify meaning of Training / Synch. Sequence Code ...................................................................... TRXD: further clarify meaning of Training / Synch. Sequence Code Both Synch. sequence and Training sequence are basically the same thing, only the length is different. I guess this is why 3GPP TS 45.002 names them differently. Let's mention them both to avoid confusion. Change-Id: I092af5ef6b66f8bdbd46cc3ae0c77fd806f2fe27 --- M common/chapters/trx_if.adoc 1 file changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/62/29162/1 diff --git a/common/chapters/trx_if.adoc b/common/chapters/trx_if.adoc index 9638133..a7be07c 100644 --- a/common/chapters/trx_if.adoc +++ b/common/chapters/trx_if.adoc @@ -569,15 +569,15 @@ .MTS field structure ---- -+-----------------+---------------------------------------+ -| 7 6 5 4 3 2 1 0 | bit numbers (value range) | -+-----------------+---------------------------------------+ -| X . . . . . . . | NOPE / IDLE frame indication (0 or 1) | -+-----------------+---------------------------------------+ -| . X X X X . . . | Modulation, TS set number (see below) | -+-----------------+---------------------------------------+ -| . . . . . X X X | Training Sequence Code (0..7) | -+-----------------+---------------------------------------+ ++-----------------+----------------------------------------+ +| 7 6 5 4 3 2 1 0 | bit numbers (value range) | ++-----------------+----------------------------------------+ +| X . . . . . . . | NOPE / IDLE frame indication (0 or 1) | ++-----------------+----------------------------------------+ +| . X X X X . . . | Modulation, TS set number (see below) | ++-----------------+----------------------------------------+ +| . . . . . X X X | Training / Synch. Sequence Code (0..7) | ++-----------------+----------------------------------------+ ---- NOPE / IDLE frame indication (referred to as NOPE.ind):: @@ -618,11 +618,11 @@ consisting of a sequence of four Access Bursts (see 3GPP TS 44.060). The transceiver shall use `0110` as the modulation type to indicate that. -Training Sequence Code:: -The Training Sequence Code identifies the Training Sequence of a received -burst. The value of this field corresponds to one of the sequences defined -in 3GPP TS 45.002, section 5.2, and depends on the actual modulation and -the TSC set indicated by the preceding bits. +Training / Synch. Sequence Code:: +In combination with a modulation type and a TS set number, this field uniquely +identifies the Training Sequence of a received Normal Burst (see tables 5.2.3a-d) +or Synchronization Burst (see table 5.2.5-3), or the Synch. Sequence of a +received Access Burst (see table 5.2.7-3 and 5.2.7-4). ==== Downlink Data Burst -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I092af5ef6b66f8bdbd46cc3ae0c77fd806f2fe27 Gerrit-Change-Number: 29162 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-pfcp[master]: RPM: fix configure and typo "gltv" in .spec.in
by osmith 19 Aug '22

19 Aug '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 ) Change subject: RPM: fix configure and typo "gltv" in .spec.in ...................................................................... RPM: fix configure and typo "gltv" in .spec.in Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 --- M contrib/libosmo-pfcp.spec.in 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved neels: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 9e2c06a..286a644 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -71,7 +71,8 @@ %build echo "%{version}" >.tarball-version autoreconf -fi -%configure +%configure \ + --includedir="%_includedir/%name" make %{?_smp_mflags} %install @@ -87,7 +88,7 @@ %postun -n libosmo-pfcp0 -p /sbin/ldconfig %files -n libosmo-gtlv0 -%{_libdir}/libosmo-gltv.so.0* +%{_libdir}/libosmo-gtlv.so.0* %files -n libosmo-gtlv-devel %dir %{_includedir}/%{name} -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 Gerrit-Change-Number: 29115 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log