- gerrit-log - lists.osmocom.org

Change in ...osmo_dia2gsup[master]: server_cb: Improve handling resynchronization info
by fixeria 19 Aug '22

19 Aug '22

Attention is currently required from: laforge, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 ) Change subject: server_cb: Improve handling resynchronization info ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2aad313d4d37d07040bc5344de3a023d34fd8ded Gerrit-Change-Number: 20021 Gerrit-PatchSet: 3 Gerrit-Owner: matt9j <matt9j(a)cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Fri, 19 Aug 2022 15:30:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: cosmetic: add spec reference
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158 ) Change subject: cosmetic: add spec reference ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29158/comment/387a276a_ad5d637e PS1, Line 184: /* ITU-T Rec Q.713 */ this spec is about SCCP, not SUA? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: cosmetic: constify function parameters, return proper error
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 ) Change subject: cosmetic: constify function parameters, return proper error ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/8dc9229f_2543b9c4 PS1, Line 7: cosmetic: constify function parameters, return proper error the summary should indicate the scope ("sccp_scoc.c:...") Patchset: PS1: please separate "constify" and "change rc" in distinct commits File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/a872b49f_f0fa1b93 PS1, Line 704: return -ENOMSG; -ENOMEM would be the proper code here. but actually, none of the callers even look at the return code. what is this change about? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I398e3efa3e097de8907617cfdf363e1d3b96f666 Gerrit-Change-Number: 29159 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:49:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29082/comment/80d6a6e6_eb3b114b PS1, Line 9: Log error code and amount of data - both are handy for debugging apps using the library. commit log line width is typically 72 this summarizes well: https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-forma… -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:44:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: update git URLs (git -> https; gitea)
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29147 ) Change subject: update git URLs (git -> https; gitea) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i'm not sure about changing git URLs, in principle: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/… -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7e0190b36861710d8cc8dd0cfd50d3dbe301ede5 Gerrit-Change-Number: 29147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:34:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-hnodeb[master]: configure.ac: do not require unused dlopen
by fixeria 19 Aug '22

19 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/29105 ) Change subject: configure.ac: do not require unused dlopen ...................................................................... configure.ac: do not require unused dlopen Change-Id: Idd4a816babcfb2e2302fbd21cb48989659940d5c --- M configure.ac 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/configure.ac b/configure.ac index f21a9a9..760c0b2 100644 --- a/configure.ac +++ b/configure.ac @@ -37,8 +37,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) old_LIBS=$LIBS AC_SEARCH_LIBS([sctp_recvmsg], [sctp], [ AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/29105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idd4a816babcfb2e2302fbd21cb48989659940d5c Gerrit-Change-Number: 29105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-gsm-manuals[master]: TRXD: further clarify meaning of Training / Synch. Sequence Code
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29162 ) Change subject: TRXD: further clarify meaning of Training / Synch. Sequence Code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I092af5ef6b66f8bdbd46cc3ae0c77fd806f2fe27 Gerrit-Change-Number: 29162 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnodeb[master]: configure.ac: do not require unused dlopen
by neels 19 Aug '22

19 Aug '22

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/29105 ) Change subject: configure.ac: do not require unused dlopen ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/29105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idd4a816babcfb2e2302fbd21cb48989659940d5c Gerrit-Change-Number: 29105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto
by Christian Amsüss 19 Aug '22

19 Aug '22

Attention is currently required from: laforge, pespin, dexter. Christian Amsüss has removed a vote from this change. ( https://gerrit.osmocom.org/c/pysim/+/29033 ) Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Removed Code-Review+2 by Christian Amsüss <chrysn(a)fsfe.org> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto
by Christian Amsüss 19 Aug '22

19 Aug '22

Attention is currently required from: laforge, pespin, dexter. Christian Amsüss has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29033 ) Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Aug 2022 14:22:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log