- gerrit-log - lists.osmocom.org

Change in pysim[master]: proactive: Send a Terminal Response automatically after a Fetch
by laforge 21 Aug '22

21 Aug '22

Attention is currently required from: Christian Amsüss. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29067 ) Change subject: proactive: Send a Terminal Response automatically after a Fetch ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I43bc994e7517b5907fb40a98d84797c54056c47d Gerrit-Change-Number: 29067 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Comment-Date: Sun, 21 Aug 2022 13:16:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: proactive: Avoid clobbering the output of the command that triggered ...
by laforge 21 Aug '22

21 Aug '22

Attention is currently required from: Christian Amsüss. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29066 ) Change subject: proactive: Avoid clobbering the output of the command that triggered the FETCH ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b794a5c5bc808b9703b4bc679c119341a0ed41c Gerrit-Change-Number: 29066 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Comment-Date: Sun, 21 Aug 2022 13:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()
by fixeria 21 Aug '22

21 Aug '22

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 2: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29082/comment/5a3b30ff_195c87a7 PS2, Line 1334: ret Somehow I missed this. According to man: "Upon successful completion, send() shall return the number of bytes sent. Otherwise, -1 shall be returned and errno set to indicate the error." So here you should do strerror(errno) instead. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 13:13:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: BSSMAP: add assert to reset resending
by msuraev 21 Aug '22

21 Aug '22

Attention is currently required from: neels, pespin, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 ) Change subject: BSSMAP: add assert to reset resending ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Either I am doing something wrong or... […] Indeed - see the related ticket: in the absense of config and core files the best guess I have is that smth else has caused the stack corruption which resulted in this crash. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48 Gerrit-Change-Number: 28892 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 13:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: Add basic readme for example code
by msuraev 21 Aug '22

21 Aug '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29169 ) Change subject: Add basic readme for example code ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4c76a48a76ca9afc960ea2f08229bacc79b6fe77 Gerrit-Change-Number: 29169 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 21 Aug 2022 13:04:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper
by msuraev 21 Aug '22

21 Aug '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 21 Aug 2022 13:04:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: error if attempting to send exceedingly big data
by msuraev 21 Aug '22

21 Aug '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29168 ) Change subject: SIGTRAN: error if attempting to send exceedingly big data ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8a67bc40080eb1405ab3b0df874e3ea20941a850 Gerrit-Change-Number: 29168 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 21 Aug 2022 13:04:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: don't advance FSM on failed connection request
by msuraev 21 Aug '22

21 Aug '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 ) Change subject: SIGTRAN: don't advance FSM on failed connection request ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8431c77632014e2551d1da779afddffcd1bb541c Gerrit-Change-Number: 29167 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 21 Aug 2022 13:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()
by msuraev 21 Aug '22

21 Aug '22

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Log more details in osmo_stream_srv_write() Log error code and amount of data: both are handy for debugging apps using the library. Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f --- M src/stream.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: msuraev: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream.c b/src/stream.c index cdd0eae..dc44a1c 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1294,8 +1294,6 @@ struct llist_head *lh; int ret; - LOGP(DLINP, LOGL_DEBUG, "sending data\n"); - if (llist_empty(&conn->tx_queue)) { osmo_fd_write_disable(&conn->ofd); return; @@ -1304,6 +1302,8 @@ llist_del(lh); msg = llist_entry(lh, struct msgb, list); + LOGP(DLINP, LOGL_DEBUG, "sending %u bytes of data\n", msg->len); + switch (conn->srv->sk_domain) { case AF_UNIX: ret = send(conn->ofd.fd, msg->data, msg->len, 0); @@ -1331,7 +1331,7 @@ ret = -ENOTSUP; } if (ret < 0) { - LOGP(DLINP, LOGL_ERROR, "error to send\n"); + LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", strerror(-ret)); } msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()
by msuraev 21 Aug '22

21 Aug '22

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 13:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log